Comments (3)
I think we should just remove that sentence from the docs. This seems like an extraneous check the implementation would have to do for little benefit. If we are worried that users might inadvertently calculate NumEntries to be zero, we can add a check for this in loader's validation layer (that hopefully will someday exist :-)).
From a cursory glance, linux syscalls don't check things like this (e.g., in writev
/readv
).
from unified-runtime.
I'm not sure. This check in implemented in PI here https://github.com/intel/llvm/blob/sycl/sycl/plugins/level_zero/pi_level_zero.cpp#L2527. It also aligns with OpenCL https://registry.khronos.org/OpenCL/sdk/1.0/docs/man/xhtml/clGetDeviceIDs.html. However, if you believe that this can be done at the loader level then that seems fine with me. I don't know enough about the loader to comment.
from unified-runtime.
I think, in the short term at least, there's value to adding these.
Once we have a validation layer we can reconsider where those types of checks should reside.
from unified-runtime.
Related Issues (20)
- Clang is not used in Windows builds in Github Actions workflow HOT 4
- [CUDA] Adapater build error with CUDA toolkit version less than 12 HOT 3
- Provide support for Intel's extensions for Kernel Binaries in urKernelGetInfo HOT 1
- Change to CMake options to build all adapters HOT 7
- Consider adding PROGRAM_INFO_IL HOT 1
- Potential better handling of python dependencies during configuration
- Automatically detect targets for CTS device binaries.
- Consider adding UR_PLATFORM_INFO_ADAPTER to ur_platform_info_t HOT 1
- Error handling for unsupported adapter features
- [NATIVE_CPU] Cannot build UR with native cpu support HOT 4
- Visual Studio OpenCL adapter build error
- Consider to add a new error code for `urVirtualMemMap` when the VA is already mapped HOT 6
- Add tests for the Sanitizer Layer HOT 2
- Inconsistent behavior between UR_DEVICE_INFO_UUID vs UR_DEVICE_INFO_PCI_ADDRESS HOT 11
- [CUDA] Print a warning when loading the CUPTI library fails
- [CUDA] Improve the loading process of the CUPTI library when tracing HOT 1
- Ensure in CTS getInfo tests that Object creation handles is the same as queried
- Improve compiler interface testing
- [NATIVE_CPU] UR compilation error with native cpu support HOT 4
- Request to add a new UR API to retrieve global variable pointer from Module HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unified-runtime.