Coder Social home page Coder Social logo

Comments (3)

pbalcer avatar pbalcer commented on July 30, 2024

I think we should just remove that sentence from the docs. This seems like an extraneous check the implementation would have to do for little benefit. If we are worried that users might inadvertently calculate NumEntries to be zero, we can add a check for this in loader's validation layer (that hopefully will someday exist :-)).

From a cursory glance, linux syscalls don't check things like this (e.g., in writev/readv).

from unified-runtime.

veselypeta avatar veselypeta commented on July 30, 2024

I'm not sure. This check in implemented in PI here https://github.com/intel/llvm/blob/sycl/sycl/plugins/level_zero/pi_level_zero.cpp#L2527. It also aligns with OpenCL https://registry.khronos.org/OpenCL/sdk/1.0/docs/man/xhtml/clGetDeviceIDs.html. However, if you believe that this can be done at the loader level then that seems fine with me. I don't know enough about the loader to comment.

from unified-runtime.

kbenzie avatar kbenzie commented on July 30, 2024

I think, in the short term at least, there's value to adding these.

Once we have a validation layer we can reconsider where those types of checks should reside.

from unified-runtime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.