Comments (6)
This could be UR_RESULT_ERROR_INVALID_OPERATION
instead. However looking at urVirtulMemMap spec, UR_RESULT_ERROR_INVALID_VALUE
isn't listed as a valid return value. Will need to update the spec either way.
from unified-runtime.
For the sanitizer we'd ideally have a dedicated error code for VA already having a physical mapping, because in that case it essentially means "success". Using a generic error code like invalid operation might lead to it being reused later on for something different.
from unified-runtime.
For the sanitizer we'd ideally have a dedicated error code for VA already having a physical mapping, because in that case it essentially means "success". Using a generic error code like invalid operation might lead to it being reused later on for something different.
Yes, I totally agree. But if we can document that "UR_RESULT_ERROR_INVALID_OPERATION" only means the VA is already mapped but not other reasons, I think using the existing error code is fine as well.
from unified-runtime.
Related Issues (20)
- Change to CMake options to build all adapters HOT 7
- Consider adding PROGRAM_INFO_IL HOT 1
- Potential better handling of python dependencies during configuration
- Automatically detect targets for CTS device binaries.
- Consider adding UR_PLATFORM_INFO_ADAPTER to ur_platform_info_t HOT 1
- Error handling for unsupported adapter features
- [NATIVE_CPU] Cannot build UR with native cpu support HOT 4
- Visual Studio OpenCL adapter build error
- Add tests for the Sanitizer Layer HOT 2
- Inconsistent behavior between UR_DEVICE_INFO_UUID vs UR_DEVICE_INFO_PCI_ADDRESS HOT 11
- [CUDA] Print a warning when loading the CUPTI library fails
- [CUDA] Improve the loading process of the CUPTI library when tracing HOT 1
- Ensure in CTS getInfo tests that Object creation handles is the same as queried
- Improve compiler interface testing
- [NATIVE_CPU] UR compilation error with native cpu support HOT 4
- Request to add a new UR API to retrieve global variable pointer from Module HOT 2
- Add validation layer support to detect if maps from urEnqueueMemBufferMap are overlapping
- [CUDA] Segmentation fault in CTS enqueue tests HOT 1
- [HIP] Couldn't find the HSA include directory HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unified-runtime.