Coder Social home page Coder Social logo

Comments (6)

kbenzie avatar kbenzie commented on September 17, 2024

This could be UR_RESULT_ERROR_INVALID_OPERATION instead. However looking at urVirtulMemMap spec, UR_RESULT_ERROR_INVALID_VALUE isn't listed as a valid return value. Will need to update the spec either way.

from unified-runtime.

pbalcer avatar pbalcer commented on September 17, 2024

For the sanitizer we'd ideally have a dedicated error code for VA already having a physical mapping, because in that case it essentially means "success". Using a generic error code like invalid operation might lead to it being reused later on for something different.

from unified-runtime.

AllanZyne avatar AllanZyne commented on September 17, 2024

For the sanitizer we'd ideally have a dedicated error code for VA already having a physical mapping, because in that case it essentially means "success". Using a generic error code like invalid operation might lead to it being reused later on for something different.

Yes, I totally agree. But if we can document that "UR_RESULT_ERROR_INVALID_OPERATION" only means the VA is already mapped but not other reasons, I think using the existing error code is fine as well.

from unified-runtime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.