omyradio / radio Goto Github PK

Some DJ's do not like to be recorded. Some like to review the recordings of their shows before deciding if they want to make them public. And out of principle we should not record if DJ's don't agree.

So I suggest we make seperate mountpoints for recording. This way DJ's can decided to stream to the mountpoints that are recorded.

now recordings of a show you want to hear are hard to find

we should have some metadata in the name

Currently we do recordings with a bitrate of 320 - it would be cool to have maxOf(live.bitrate , 320)

# dump live_dj recordings to a file
timestamp = '%H-%M--%d-%m-%Y'
output.file(%mp3(bitrate=320, id3v2=true), reopen_on_metadata=false, "#{basedir}/audio/rec/OMYLiveRecordedOn#{timestamp}.mp3", live, fallible=true)

Symptoms:
When a dj tries to stream the encoder seems to connect but says disconnected immidiately.
In the liquidsoap log we see lines like the following:
2021/04/24 16:55:59 [input(dot)harbor_9166:3] Incorrect stream type! 2021/04/24 16:55:59 [mksafe:3] Switch to safe_blank with forgetful transition. 2021/04/24 16:55:59 [input(dot)harbor_9166:2] Feeding stopped: Generator.Incorrect_stream_type.

This happened thursday. Minivibs had to cancel his show. Same night I tried to stream and had the same problem. After restarting liquidsoap service I was able to stream again.

Saturday when starting the dubfabrikken session the same problem occured. I tried to restart liquidsoap service but this time the problem persisted after restart. To check if we had a client side problem we asked Dolle to stream. He was able to stream normally at first. Then he tried again and had the same problem. Everytime the same lines in the liquidsoap log.
Then suddenly, after a 3rd restart of liquidsoap service, we were able to start streaming normally. Then we ran the session without issues from that one (not touching a thing!).

So it seems like we have some kind of race condition or other condition that makes the problem only happens sometimes. This condition seems to sometimes come up after liquidsoap has been running for some time without issues. And also it seems the condition can come up right after restart. Or it might be trigged by clients and be pure coincidence the pattern we see with different dj's having the problem and working again after restart.

maybe we can do some song detection for people that stream from vinyl and do not add MetaData manually