omjoonkim / githubbrowserapp Goto Github PK
View Code? Open in Web Editor NEWGitHubBrowserApp on kotlin + rxJava2 + AAC+ retrofit2 + mvvm + koin + cleanArchitecture(modularization)
GitHubBrowserApp on kotlin + rxJava2 + AAC+ retrofit2 + mvvm + koin + cleanArchitecture(modularization)
gson
/ apiClient
/ gitHubDataRepository
변수 모두 environment
라는 변수를 통해 제공이 되고 있습니다.
위의 변수들을 private 으로 두지 않는다면 environment 로서 따로 제공하는 의미가 없을 듯 합니다.
gitHubDataRepository
는 apiClient
를 Wrapping 하여 기능을 하고있습니다.
즉 environment 변수에서 apiClient 를 따로 제공할 필요가 없습니다.
실제로 environment 변수에서 apiClient 를 받아서 사용하는 경우가 존재하지 않습니다.
enviroment -> environment
Endpoint
라는 object name 에 baseUrl
밖에 존재하지 않습니다.
endpoint 변수를 추가한다면 필요한 object 가 되겠으나 현재 그렇게 사용하고 있지 않으니 제거하는 것이 어떨까요?
baseUrl
자체를 build.gradle
내의 buildConfigField
변수로 정의해놓는 것이 어떨까요?
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.