omegajak / power_drop Goto Github PK

This is for the versions 1.19.4-2.1.1 and 1.20.1-2.2.0.

Looks like I registered the KeyMapping wrong.

Will fix and release updated versions for 1.19.4 and 1.20.1.

When both the vanilla drop keybind and power drop keybind are on the same key, it causes both to activate at the same time. While this specific issue goes away once the vanilla drop is bound to something else, this also means the vanilla drop cannot be used at all (for example, while hovering over items and pressing Q in the inventory). Ideally power drop should still be usable when bound to the same key as vanilla drop; it should just detect if the user is holding the drop key, for example. This bug is present in the mod for 1.12.2; I do not know if it is present in newer versions as well.

Before the 1.18 rewrite, items were thrown exactly along the vector the player was looking. After, they're thrown a little above it.

This is because after the 1.18 rewrite, Power Drop is just multiplying the dropped item's velocity, which means it is the same random(ish) vector that vanilla drops happen along.

Ideally, power drop would adjust the vector to be directly where the player is looking. This would allow more precision.

This appears to be missing in all current 2.x versions. No animation is played for power drop, while one is played for vanilla drop.

I'm getting this crash with 1.1.1 of your mod:

https://git.io/vxLUW

Do you perhaps mistakenly upload a dev build to Curse?

Title. Just a simple whooshing sound effect of some sort, would be a nice touch. If possible, make the volume of the sound scale with the strength of the drop.

This caused an issue with trying to tame rats (AlexModGuy/Rats#136) from the Rats mod. When cheese was thrown, the cheese item didn't know who threw it, making rats untameable using Power Drop.