ombre-projects / ombreandroidwallet Goto Github PK

Right now the QR scanning code expects a URL like string and this works fine for wallet to wallet communication. It does not support a QR code that just consists of a wallet address and transaction ID (which is what exchanges typically use) and we should add this.

If you close the app while the wallet is syncing and reopen the app; the wallet will be confused and might show negative block number to sync.

pid: 0, tid: 0 >>> io.ombre.wallet <<<

backtrace:
#00 pc 000000000004b7e8 /system/lib/libc.so (tgkill+12)
#1 pc 000000000001a4b3 /system/lib/libc.so (abort+54)
#2 pc 000000000001edd5 /system/lib/libc.so (__libc_fatal+24)
#3 pc 000000000001a97d /system/lib/libc.so (__assert2+16)
#4 pc 000000000006bff7 /data/app/io.ombre.wallet-J142sibHqy9K3Yme7bJ22Q==/lib/arm/libc++_shared.so
m2049r#5 pc 000000000006c1a1 /data/app/io.ombre.wallet-J142sibHqy9K3Yme7bJ22Q==/lib/arm/libc++_shared.so
m2049r#6 pc 000000000007f53d /data/app/io.ombre.wallet-J142sibHqy9K3Yme7bJ22Q==/lib/arm/libc++_shared.so
m2049r#7 pc 000000000007ecb9 /data/app/io.ombre.wallet-J142sibHqy9K3Yme7bJ22Q==/lib/arm/libc++_shared.so (__cxa_throw+96)
m2049r#8 pc 00000000003c1864 /data/app/io.ombre.wallet-J142sibHqy9K3Yme7bJ22Q==/lib/arm/libmonerujo.so (ZN5tools5error15throw_wallet_exINS0_23no_connection_to_daemonEJA14_cEEEvONSt6__ndk112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEEDpRKT0+1204)
m2049r#9 pc 000000000032b750 /data/app/io.ombre.wallet-J142sibHqy9K3Yme7bJ22Q==/lib/arm/libmonerujo.so (_ZN5tools7wallet224pull_blocks_with_viewkeyEyRyS1_RNSt6__ndk14listIN10cryptonote20block_complete_entryENS2_9allocatorIS5_EEEERNS2_6vectorINS4_16COMMAND_RPC_DATA20block_output_indicesENS6_ISC_EEEE+1784)
m2049r#10 pc 00000000003b645c /data/app/io.ombre.wallet-J142sibHqy9K3Yme7bJ22Q==/lib/arm/libmonerujo.so
m2049r#11 pc 000000000066f92c /data/app/io.ombre.wallet-J142sibHqy9K3Yme7bJ22Q==/lib/arm/libmonerujo.so
m2049r#12 pc 0000000000048aff /system/lib/libc.so (_ZL15__pthread_startPv+22)
m2049r#13 pc 000000000001b323 /system/lib/libc.so (__start_thread+32)

The wallet uses a cacerts file to verify certificates from nodes. This file is currently copied to "ombre_wallet" upon first startup but this appears to be too late: the first time you run the application the wallet cannot connect to SSL nodes.

How to verify:

• Remove the ombre_wallet directory from sdcard
• Start the wallet and try to connect -> fail
• Close the wallet app and restart it.
• Try to connect and it works

The logcat messages also clearly show this issue.

This mechanism needs to change to ensure the cacerts file is prior to loading the wallet shared libraries.