oma-wc / oma Goto Github PK

Links are missing discernible name. Currently, there's only an icon available, no text.

If using oma-link with for instance an http link, you get the following reference error: Uncaught (in promise) ReferenceError: ParseError is not defined.

Should we replace Lerna with Yarn 2?

Currently, only one oma-google-calendar is supported on a page due to this code:

const getElementByDataHandle = (handle) =>
  document.querySelector('[data-handle="' + handle + '"]')
const contentSwitch = getElementByDataHandle('oma-google-calendar')

Instead of searching the whole document, we should search within the component.

The current solution for setting stylesheet rules creates a lot of FOUC. They are written in a useEffect hook, like this:

  useEffect(() => {
    State.stylesheet.write()
  })

This is problematic, especially for components like oma-site which is not completely rendered before all things inside it is rendered. That means, we are basically writing the Oma stylesheet on DOMContentLoaded, which is terribly late in the rendering process! In oma-site, we set a lot of custom properties that we use on a lot of places. Until the component is rendered, these custom properties are undefined...

Our default breakpoints are working a lot better though, they are not run inside useEffect.

The HTTP link should make use of the internal LinkTag component. I just don't know how to pass the slot content to that component...

This would proabably reduce overall size when loading more than a few component from oma.

Currently, oma-link only supports phone and email links.

Lists do not contain only

When importing State with: import { State } from '@oma-wc/state', the built code produces this error:

Uncaught TypeError: Class constructor Singleton cannot be invoked without 'new'

This is the built code that raises the error:

const State$1 = Singleton();

The weird thing is that this code is also present in other packages builds, so I have no idea why only this package build produces this error.

It would be nice to be able to display the localized name of the weekday. See https://stackoverflow.com/questions/24998624/day-name-from-date-in-js for implementation suggestion.

The CommonJS version of the internal/common/state component is broken. The line Object.defineProperty(exports, '__esModule', { value: true }); in the build code gives the following error when included as a script:

Uncaught ReferenceError: exports is not defined

We have missed to check if the phone number parses correctly. We get Uncaught (in promise) TypeError: Cannot read property 'isValid' of undefined