ollitietavainenvaadin / file-download-wrapper Goto Github PK

Hi,

The current version of the plugin is not compatible with Vaadin 24 because it has a dependency on PolymerTemplate.

hi there,

could you please remove the banner.txt file from the resources folder? It overwrites the default spring boot banner and I really like the default spring boot banner 🙂

(I just don't want to create a custom banner in every project where I use this component, and I'd rather see the default spring boot banner, really.)

Thanks,
Vilmos

Version 7.0.0 has a dependency to Vaadin 24.0.0.beta4
Any chance to update this to a released version? If you prefer, I will create an PR.

Hi,

Could you please remove https://dl.bintray.com/webjars/maven from your pom since it is not accessible anymore and forces the vaadin project build to print out a warning beside a build delay while trying to fetch the artefact.

webjars can be fetched from maven central and has not been updated the last few years.

THX

This project is dead, isn't it?

There is the general assumption that one cannot disable the FileDownloadWrapper, but only the wrapped button. This is not true.

all the FileDownloadWrapper class needs is this additional method:

public void disable() {
    this.anchor.removeHref();
}

If this method is called (and the wrapped button is disabled as well, using setEnabled(false)) the download button is truly disabled. You can enable it again using setResource(...) and wrappedButton.setEnabled(true)

Currently this is only possibly by extending FIleDownloadWrapper with your own class, as anchor is protected and does not have a getter.

Could I ask that this disable() method be added to the actual FileDownloadWrapper class, so everyone has direct access to disable the download button properly?