olivierlsc / angular-page-visibility Goto Github PK

I have Ivy enabled in my ng10 project and the lib seems to work fine - am I missing something or is the readme file maybe outdated?

And disable Ivy in tsconfig.json :

{
...
"angularCompilerOptions": {
...
"enableIvy": false
}

@olivierlsc

It would be great to let the library support Angular 7. Currently it's not supported because of the peer dependencies: you just get errors:

ERROR in node_modules/angular-page-visibility/lib/angular-page-visibility.service.d.ts(1,10): error TS2305: Module '"C:/Projects/NGP/Frontend/node_modules/rxjs/Observable"' has no exported member 'Observable'.
node_modules/rxjs/Observable.d.ts(1,15): error TS2307: Cannot find module 'rxjs-compat/Observable'.

you cannot decorate a method with @OnPageVisible() and access this from inside that method

Hi,

Angular page visibility does not work with SSR (universal) rendering.
At runtime we get

Error: document is not defined: Error during instantiation of AngularPageVisibilityService!. caused by: document is not defined

Thanks

npm WARN [email protected] requires a peer of @angular/common@^7.2.12 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of @angular/core@^7.2.12 but none is installed. You must install peer dependencies yourself.

I couldn't wait so I forked it: https://github.com/Lauriy/angular-page-visibility

And published my own alias: https://www.npmjs.com/package/angular-page-visibilityx

Thanks for your work.

hi do you have any idea about this error !?

ERROR in node_modules/angular-page-visibility/lib/angular-page-visibility.service.d.ts(1,10): error TS2305: Module '"/home/thunder/projects/pwa/pilapet-website/node_modules/rxjs/Observable"' has no exported member 'Observable'.
[ng] node_modules/rxjs/Observable.d.ts(1,15): error TS2307: Cannot find module 'rxjs-compat/Observable'.

When upgrading my project to Angular 6, I'm getting the following compile error:

ERROR in Error during template compile of 'AngularPageVisibilityModule'
Function calls are not supported in decorators but 'ɵmakeDecorator' was called in 'NgModule'
'NgModule' calls 'ɵmakeDecorator'.

Any ideas for how I can address this? Thanks!

when my browser is full screen then your library is not working.

It seems that OnPageHidden doesn't work in iOS when minimizing mobile browsers like Chrome and Safari, I am working on disconnecting a web socket connection once the browser is minimized

this :

import { AngularPageVisibilityModule } from 'ngx-page-visibility';

should be :

import { NgxPageVisibilityModule } from 'ngx-page-visibility';

First off, awesome lib you made!! Many thanks!! Just a quick question / freature request; do you intent supporting AoT? If not, feel free to close the issue, if so, I'm looking forward to it :)

It works for members of a component but not for injected services.

export class TestComponent{
 ...
    @OnPageVisible()   
        pageVisible(): void {   
            this.isPageVisible = true;   
        }   

    @OnPageHidden()   
        pageHidden(): void {   
            this.testService.doSomthing().subscribe()   
        }   
}

The OnPageVisible() works but OnPageHidden() throws this.testService is undefined.

When building with aot option, following error occurs. ng build --prod

ERROR in Error during template compile of 'AngularPageVisibilityModule'
  Function calls are not supported in decorators but 'ɵmakeDecorator' was called in 'NgModule'
    'NgModule' calls 'ɵmakeDecorator'.