oliverh57 / vision Goto Github PK

the way you are handling authentication is by setting a cookie to a string kept in a config file.

this is very insecure and you should use a different method, because anyone who intercepts the cookie knows the authentication secret.

at the very least, you should hash it in some way.

In the licence file, LICENCE, it says that this is MIT licenced by "Oliver Hynds".

However in the footer of the website it says "Copyright Oliver Hynds, Robert Bradshaw, Ben Griffiths and W3Schools".

This is:

1. inconsistent as the list of creators differs in different locations
2. misleading as the footer of the website just says "copyright" without indicating how the system is licenced.
3. wrong because it attributes w3schools as a creator of the website. This is not the case. If you want to credit w3schools for creating w3.css, you should not do this in with "copyright" as this means w3schools could claim copyright on this system if they so desired

1. your versioning system is all messed up and doesn't follow semver.
2. you are using a mix of forward slashes (/) and backslashes (\) in your instructions. You should be more consistent.
3. many things in your installation instructions are incorrectly spelled.

since my last issue, #9, your versioning system has got even worse.

In case you didn't know, the major number is only supposed to change if this version makes something backwards-incompatible. Not when you make a big change. That's for the middle number.

Additionally, you can't just go around changing the version numbers of previous versions willy-nilly. What is this, 1984?