olament / hanzi2pinyinengine

Hanzi to Pinyin engine in Swift 拼音输入法引擎

Hi there 👋  

hanzi2pinyinengine's Issues

Pinyin2HanziEngine/SLMGraph.swift:121: Fatal error: Unexpectedly found nil while unwrapping an Optional value

when input nihaoshijie, the app crashed:

Pinyin2HanziEngine/SLMGraph.swift:121: Fatal error: Unexpectedly found nil while unwrapping an Optional value

https://github.com/Olament/Hanzi2PinyinEngine/blob/master/Pinyin2HanziEngine/Graphs/SLMGraph.swift#L121
var currentIndex = self.edgeTo[self.vertexCount - 1]!.from.id This line thrown the exception.

I tried refactor the code to prevent the exception, but then I can't get any solution result.

Also tried to check out 01bee8a47, it works, can get multiple senctences for the input nihaoshijie, but the sort/order looks odd, not correct.

Can you help to give some hint for this?

Memory leak in SyllableGraph

It returns only 1 result

Hi Olament, thanks for sharing the project.
I've cloned and checked that, but I found that the program only gave a result as the screenshot below.
The code in SMLGraph.swift also showed that It only gave a result as below.

// code in SLMGraph.swift , func of makSentence()
     func makeSentence() -> Solution {
        self.distanceTo[0] = 0 // set the starting vertex to zero

......
            while currentIndex != 0 {
                solution.pinyin = self.vertices[currentIndex].data!.pinyinSequence!.pinyinSequence + solution.pinyin
                solution.sentence = self.vertices[currentIndex].data!.phrase! + solution.sentence
                currentIndex = self.edgeTo[currentIndex]!.from.id
            }

.......
return solution
}

So, I just wonder that is this the final version of your code? Would you mind to update your final version of code which can give the multiple results?

Thanks a lot!