ojdx / react-font-face Goto Github PK

If only setting a single font the config should accept a json object and not require an array. I only suggest this since the majority of use will just add a single font of either type

Expand on readme instructions for running tests, usage, contributions.

pass in the name of font based on google font lists, also indicate that youre using google; as opposed to your own local file or an array of fonts

This is not true any more
https://github.com/ojdx/react-font-face/blob/develop/src/react-font-face.js#L48
This pipe at the end should be removed cause it does break the request now
see for yourself
https://fonts.googleapis.com/css?family=Exo|

consider adding googleFontImportString.slice(0, -1) here https://github.com/ojdx/react-font-face/blob/develop/src/react-font-face.js#L51

Thank you for the lib.
I've used it before until this issue arised.

need to validate existence on setting state in constructor
google: config.google.length > 0 ? config.google : [],
file: config.file.length > 0 ? config.file : [],

check if google is present or file is present
if neither is there it should throw an error

allow the usage of your own font file

get travis ci set up

get some sweet testing in there.

use babel 2016