oiv / denyactions Goto Github PK

@oiv Hi... the denyrev doesn't seem to work. I have:

$conf['plugin']['denyactions']['denyactions'] = 'revisions';
$conf['plugin']['denyactions']['denyrev'] = 1;

But old revisions are still accessible to READ users.

In fact, I don't see how the action/*php are included?

In the export_*-actions, $REV is used, too. There it is without the TPL_ACT_RENDER-event. Further, diffs can be shown in the feed. Maybe also old revisions of files might be an issue? This is probably yet another event. Probably it makes sense to hook into ACTION_ACT_PREPROCESS to catch as many events from the main script as possible. Further, FETCH_MEDIA_STATUS is needed for media files (they also have $REV) and FEED_OPTS_POSTPROCESS for the feed (disable diff content if the diff action has been disabled).

I wonder also if some other actions should be disabled automatically when old revisions are disabled (like diff, recent, revisions) as otherwise disabling old revisions doesn't make much sense.

• Does not work for me with DokuWiki 2020-07-29 “Hogfather” :-(
• Results in a Blank Page “Fatal error: Declaration of action_plugin_denyactions::register(Doku_Event_Handler &$controller) must be compatible with dokuwiki\Extension\ActionPlugin::register(Doku_Event_Handler $controller) […]”
• DokuWiki recovery script reported a "C Locale seems not to be a UTF-8 locale, that may cause trouble"
• Work around: Disable denyactions plugin by adding “$plugins['denyactions'] = 0;” to your /conf/plugins.local.php

Thanks and best regards from Berlin