Add test to ensure that all characters are valid UTF-8 about phenotypelibrary

[gowthamrao]

I propose converting any non-utf8 encoded characters to their utf8 counterparts (e.g. "Sjögren's syndrome")
@ablack3 agreed.

Similar issue OHDSI/ROhdsiWebApi#139

Adding a test that would check to make sure all text files contain only valid utf8 characters

good idea. I think we might benefit from a function that scans contributed json, sql and file names. Optionally makes conversion.
we can add a maintenance script here https://github.com/OHDSI/PhenotypeLibrary/tree/master/extras

Adding a dataframe/tibble to the package that would contain one row per cohort with metadata, json (as a list column), and sql (as a list column) so that loading the package in R would provide instant access to all phenotype and cohort data the package provides.

This repository, although has a R package in it - is not designed to be used exclusively in an R package. We want to expose each item separately. i.e. we want to be able to do pull request to change one file (e.g. change on json expression of one cohort within a phenotype). ie. the content here should be modified https://github.com/OHDSI/PhenotypeLibrary/tree/master/inst

if we want another file that is essentially appending these individual content into one dataframe object - thats fine by me (as part of package maintenance)

[ablack3]

Sounds good. I have a PR with

• A automated test to check for non-utf8 characters in json and sql files
• A script that converts all json files to utf8
• Code to build a dataframe from the souce files in the inst directory as part of package maintenace

This repository, although has a R package in it - is not designed to be used exclusively in an R package. We want to expose each item separately. i.e. we want to be able to do pull request to change one file (e.g. change on json expression of one cohort within a phenotype). ie. the content here should be modified https://github.com/OHDSI/PhenotypeLibrary/tree/master/inst

if we want another file that is essentially appending these individual content into one dataframe object - thats fine by me (as part of package maintenance)

Yes that's my thought too. The package dataframe is derived from the files in the inst folder. It can be quickly recreated each time those files are updated. The dataframe provides easy access to the phenotype library from R as an alternative to users needing to read in files from the inst directory. The phenotype library dataframe is a downstream/derived object.

[gowthamrao]

Names now conform to atlas cohort name constraints