oguzbilgener / bmrng Goto Github PK

I just started using the library and even though I overall really like it, this specific design decision surprised me a bit!

It seems too opinionated to force this signature onto the caller. More specifically, the current behaviour of the library can always be built on top of a "consuming" signature. One simply has to wrap the responder in an Option if desired.

However, from my usage experience so far, Responder is usually a local variable and hence fine to be consumed by the respond method.

What do you think?

lazy_static! {
  static ref runtime: Runtime = Builder::new_multi_thread()
    .enable_all()
    .build()
    .unwrap();
  static ref channel: (UnboundedRequestSender<i32, i32>, UnboundedRequestReceiver<i32, i32>) = bmrng::unbounded_channel::<i32, i32>();
  static ref channel_tx: UnboundedRequestSender<i32, i32> = channel.0.clone();
  static ref channel_rx: UnboundedRequestReceiver<i32, i32> = channel.1.clone();
}

Trying to be able to do something like this I guess

This can be worked around by converting it into a RequestError or using send_receive but I think the cleaner solution would be to simply implement std::error::Error for this type as well :)