Coder Social home page Coder Social logo

Comments (17)

tecton avatar tecton commented on August 10, 2024 1

Onboarding PR: #1128

from teams-toolkit-samples.

JerryYangKai avatar JerryYangKai commented on August 10, 2024

Hi @Prithvi-MSFT, after a quick test, the sample doesn't work in my local machine.
Repro step, download the app, using Teams ToolKit, press F5, in the pop-up browser, click 'install the app'.
Screen shot, in the meeting, cannot add the app, the config page is failed
image

I also raise this as an issue in the origin repository.
OfficeDev/Microsoft-Teams-Samples#1105

from teams-toolkit-samples.

prithvi7410 avatar prithvi7410 commented on August 10, 2024

@JerryYangKai - Thanks for reporting the issue. Will check on the sample issue

from teams-toolkit-samples.

Prithvi-MSFT avatar Prithvi-MSFT commented on August 10, 2024

Hi @JerryYangKai - The issue is fixed and we have pushed the changes. Could you please verify once
OfficeDev/Microsoft-Teams-Samples#1109

from teams-toolkit-samples.

JerryYangKai avatar JerryYangKai commented on August 10, 2024

Hi @Prithvi-MSFT, thanks for your quick reply.
I afraid I cannot run it in my local environment, I pull the latest changes then when I press F5, the frontend and backend terminal won't work, it will auto close after a few second. The screenshot is in the following:
image
image

Teams toolkit version 5.4.0
Node version
image

from teams-toolkit-samples.

JerryYangKai avatar JerryYangKai commented on August 10, 2024

@summzhan Sample test passed, please help review the doc part,

from teams-toolkit-samples.

summzhan avatar summzhan commented on August 10, 2024

README looks good to me.

from teams-toolkit-samples.

Prithvi-MSFT avatar Prithvi-MSFT commented on August 10, 2024

@tecton - By when will it be available in samples list ?

from teams-toolkit-samples.

tecton avatar tecton commented on August 10, 2024

@tecton - By when will it be available in samples list ?

Hi @Prithvi-MSFT, the sample is available in daily build version now. And it's expected to be released in next TTK prerelease version (next month).

from teams-toolkit-samples.

JerryYangKai avatar JerryYangKai commented on August 10, 2024

Hello @Prithvi-MSFT !
The preview version of teams toolkit has been released, after testing part of sample readme cannot render in VS Code, I created an issue and you can check it.
OfficeDev/Microsoft-Teams-Samples#1202

from teams-toolkit-samples.

summzhan avatar summzhan commented on August 10, 2024

@JerryYangKai @Prithvi-MSFT , What's the status of this sample? it's seems stucked by weeks.

from teams-toolkit-samples.

Prithvi-MSFT avatar Prithvi-MSFT commented on August 10, 2024

@JerryYangKai - Could you please guide me on the repro steps so I can create and test the issue ?

from teams-toolkit-samples.

JerryYangKai avatar JerryYangKai commented on August 10, 2024

@JerryYangKai - Could you please guide me on the repro steps so I can create and test the issue?

You can check the issue I created above, it is about the readme rendering, not the code running issue.

from teams-toolkit-samples.

Prithvi-MSFT avatar Prithvi-MSFT commented on August 10, 2024

@JerryYangKai - In issue its mentioned its in internal preview. Could you please guide how can I test this ? As the readme seem to look correct in repository

from teams-toolkit-samples.

JerryYangKai avatar JerryYangKai commented on August 10, 2024

@JerryYangKai - In issue its mentioned its in internal preview. Could you please guide how can I test this ? As the readme seem to look correct in repository

Now this version is released as preview version and can be repro.
Step 1 switch teams toolkit to pre release 5.7.X
image

Step 2 find the sample in sample gallery
image
image

Step 3 click the sample to see the readme, and the issue will come out
image
image

from teams-toolkit-samples.

Prithvi-MSFT avatar Prithvi-MSFT commented on August 10, 2024

Hi @JerryYangKai ,
I followed the steps mentioned and installed the latest pre-released version of teams toolkit and the images were loading correctly for me.
image

from teams-toolkit-samples.

JerryYangKai avatar JerryYangKai commented on August 10, 2024

Hi @JerryYangKai , I followed the steps mentioned and installed the latest pre-released version of teams toolkit and the images were loading correctly for me. image

Great!
This is the issue 2 I mentioned, how about the issue 1?
image

from teams-toolkit-samples.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.