Comments (12)
The fix was released on 1/18/2018. Might take a while to see it.
from office-js.
Glad it worked!
The fix is going to be part of the "January fork" (i.e., 16.0.9029.XXXX
). So yes, historically-speaking from looking at previous build stats, it will probably be late February by the time it's on Insiders (formerly "insiders slow"), and mid-March for the current channel. (All guesstimates, of course). But yes, it is heading your way :-)
Best!
~ Michael
from office-js.
@TheSamsterZA Hi, and thanks again for reporting this! As we believe the issue has been resolved and deployed, I'm going to close this issue. If you feel there is still an issue that needs to be re-triaged, please open a NEW issue and we will triage it. Thanks! lindalu
from office-js.
Hello,
There is another Stack Overflow question/answer here showing a similar issue for Word 2016 for Windows.
TL;DR: It looks like there's a bug in Word 2016 for Windows that affects window.devicePixelRatio
for OfficeJS add-ins that use Angular's Router, with hash location strategy enabled. This bug does not occur on Word Online using either IE11 or Chrome.
I am not sure if any other similar settings are affected - this is just the one that I happened to notice.
You can find my simple repro here.
from office-js.
Hey,
any updates on this? I'm facing the same issue
from office-js.
@TheSamsterZA try using skipLocationChange
<a routerLink="/dashboard" [routerLinkActive]="['active']" skipLocationChange>
This prevents the physical route to change and prevents the devicePixelRatio change.
from office-js.
Hey @alx-andru this sort-of works, thanks! The problem is, the very first navigation (the one that loads my add-in) causes window.devicePixelRatio
to decrease, while subsequent navigations (using Angular's Router and skipLocationChange
) do not.
To summarize, it appears that having a #
(hash) in the URL AND updating the push state of the browser's history causes window.devicePixelRatio
to decrease. The effect being, that the add-in content appears to shrink with each navigation.
So, I'm calling this a partial workaround until the OfficeJS team fix the underlying issue.
Ping @hongbo-miao and @Zlatkovsky.
from office-js.
@hongbo-miao what version number for Word 2016 would contain this fix?
from office-js.
Sorry, I am not the owner of this. I simply help create the issue in the beginning. I don't have the full status of this. I have to ask the team and then answer here.
I am looping correct PM or engineer to answer here directly.
from office-js.
I'm not the owner but I'm the original filler of the issue on SO. Thanks for looking into this.
from office-js.
The fix should be in build 16.0.9019.1000
or greater. Historically-speaking (just looking at the stats of previous builds), that should put it into the Insiders channel (formerly called Insider Fast) within ~3 weeks. And then another 2-3 weeks before it makes it to Monthly Channel (Targeted) (formerly called Insider Slow.), and another couple weeks more before it makes it to the main "current".
More info on Office Insider: https://support.office.com/en-us/article/what-is-office-insider-f4208185-b63a-4b68-9c7a-9a32d2411c16
Looking forward to hearing from you once you've had a chance to try it out. Do let us know...
from office-js.
Hello @Zlatkovsky, I have given this a go on:
Microsoft Office 365 Business
Outlook 2016 Version 1802 (Build 9020.2003 Click-to-Run)
Office Insider
and can confirm that the issue has indeed been fixed! 🎉 Thank you so much!
If my math is right, then the fix should trickle down to the main / current channel in March / April 2018, correct?
from office-js.
Related Issues (20)
- Office.context.mailbox.getCallbackTokenAsync is failing with code 9018 'internal error has occured' HOT 11
- Smart Alerts features does not work with site under Cloudflare with mTLS enable. HOT 5
- Office.context.platform issue in new oulook version on desktop HOT 4
- Insertion into Outlook Web and New Outlook desktop has wrong text alignment and missing icon HOT 7
- Fetch all links from all shapes in a document efficiently HOT 3
- mailbox.item.getInitializationContextAsync() never calls callback function in Old Windows Outlook HOT 11
- Uncaught (in promise) TypeError: s.getAsync is not a function when calling Office.context.mailbox?.item?.sessionData?.getAsync HOT 3
- Office.context.mailbox.item.addFileAttachmentFromBase64Async fails if base64 string is larger than 27892122 bytes
- Calling addFileAttachmentFromBase64Async for files like 15 MB in Outlook desktop files with "The attachment cannot be added because it is too big"
- Cannot sideload a plugin on Outlook For The Web HOT 7
- Add addFileAttachmentAsModernAttachmentAsync and addFileAttachmentAsModernAttachmentFromBase64Async feature HOT 2
- sessionData object is a function in 16.02 version of library HOT 2
- MS Word 2019 Task Pane Add-in using React fails to load in Windows Desktop, Office 2019. HOT 8
- Office.context.mailbox.item.sessionData.setAsync is undefined HOT 2
- unable to search sentence in word with track changes enabled HOT 5
- How long does is take for an Office Web AddIn to be installed in user profiles when using Integrated Apps deployment?
- addFileAttachmentAsync does not work with zip.js HOT 1
- Outlook does not notify user about add-in update HOT 2
- wanted to change page size, Margin and Orientation in word js addin HOT 3
- item.body is not an instance of Body in Outlook on the Web HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from office-js.