oec08 / nytimessearch Goto Github PK

👍 satisfactory work. A few notes after checking out the code:

• Nice to see you properly reused the single base method in search activity to fetch results for both initial load and the pagination.
• Consider moving the search field into the ActionBar using a custom ActionBar layout or with a SearchView
• Nice to see you properly used spinners and checkboxes to allow users to select filters.
• Good to see you properly sent and received relevant filters.
• One thing to consider is rather than sending and returning all the filter values separately as keys, might have introduced a serializable model (i.e SearchFilters.java) representing all the filters which were passed back and forth between activities within the bundle.
• Consider using a more robust HTTP client lib such as Retrofit or OkHttp.
• Try out the third-party ButterKnife library to simplify a lot of boilerplate findViewById() calls.

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.