Changes object has 19 possible keys but type is defined with only 3 of them about webhooks

[wolfy1339]

I think it might be easiest to introduce a new common schema for each rule type.

• BranchProtectionRuleBinary - rules where only boolean values are used
• BranchProtectionRuleMultiLevel - rules where you can select one of off, non_admins, or everyone
• BranchProtectionRuleArray - rules where an array of strings is expected, used for actor and build rules

[wolfy1339]

Can you confirm wether this is for GitHub.com and not GitHub.AE or GitHub Enterprise?
Please provide an example payload with those keys

[JamieMagee]

The required_conversation_resolution_level now has a different type in the BranchProtectionRule

webhooks/payload-types/schema.d.ts

Line 440 in 5d5bb3c

required_conversation_resolution_level: "off" | "non_admins" | "everyone";

and BranchProtectionRuleEditedEvent

webhooks/payload-types/schema.d.ts

Lines 824 to 826 in 5d5bb3c

	required_conversation_resolution_level?: {
	from: "off" | "required" | "requested_and_required";
	};

[JamieMagee]

That sounds reasonable, and it's effectively what I did in the .NET version. I think you will also need a BranchProtectionRuleNumber as well though:

webhooks/payload-types/schema.d.ts

Line 421 in 5d5bb3c

required_approving_review_count: number;

[wolfy1339]

I believe all the remaining possible keys have been added