Comments (5)
no need, it's good as is 👍🏼
from core.js.
@gr2m can I claim this issue? Where would be the right place to add a test for this, log.test.ts
or auth.test.ts
?
from core.js.
you can add the test to https://github.com/octokit/core.js/blob/master/test/issues.test.ts, that's exactly what we created this file for :)
from core.js.
Ah I just made the PR before I saw your comment. I'll move the test there and push a new commit
from core.js.
:tada: This issue has been resolved in version 3.1.4 :tada:
The release is available on:
Your semantic-release bot 📦🚀
from core.js.
Related Issues (20)
- [TypeScript] REST API route completion is not triggered HOT 9
- Remove Node version 10 from .github/workflows/test.yml
- [Typescript] request options autocomplete not working HOT 3
- Tests fail on Node v18 HOT 3
- Oktokit zipball download not including .git file in zip HOT 5
- Unfollow request with GitHub's REST api is giving me an error. HOT 7
- "Fvr.isPlainObject is not a function" during constructor HOT 1
- [FEAT]: Escape slash in request parameters to `--` HOT 3
- [DOCS]: Error response schema HOT 3
- [BUG]: Uncaught ReferenceError: global is not defined HOT 7
- [BUG]: octokit.graphql gives increasing number of duplicate HOT 1
- [BUG]: can not intercept requests with nock HOT 2
- [BUG]: Octokit version 4.2.2 has a breaking change dependency upgrade HOT 2
- https://github.com/ietf-tools/datatracker/commit/e68b9cf60c0f6771e40ed73a4f59aa47cacbb854
- Re-enable tests in `@octokit/core` using fetch dispatchers HOT 2
- Avoid JSON.stringify hack when testing responses of fetch-mock HOT 7
- Replace `toStrictEqual` with `JSON.stringify` Response assertions with `toEqual` in `core.js` HOT 1
- [BUG]: Unexpected token '{' in Safari pre 16.3 HOT 4
- [BUG]: Rest call to delete comment returns 404 HOT 3
- [MAINT]: Replace lolex with @sinon/fake-timers HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from core.js.