[BUG]: Unexpected token '{' in Safari pre 16.3 about core.js

[gr2m]

Glad you got it working!

I hope all the compliation-related problems will go away once we fully transition to ES Modules. It will happen eventually, but we cannot give an ETA unfortunately.

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[gr2m]

When using in browser, I'd recommend to use a smaller library. octokit comes with a lot of features and code and results in a big bundle size. Could you try if you see the same problem with @octokit/core.

You can also try importing from https://esm.sh. Try

import { Octokit } from 'https://esm.sh/@octokit/core@5'

to see if you see the same error. If you don't, it might be a problem how the imported octokit module is bundled in your setup

[mellson]

Thank you, @gr2m, that's very helpful input 👍🏻

I tried importing Octokit from esm.sh like this import { Octokit } from 'https://esm.sh/octokit';
And that actually works.

What I ended up on, for now, is to only import @octokit/rest in the browser instead of the full Octokit.
However, that still throws the original error - but I got past that by transpiling @octokit/core.
I just added it to our next config:

const nextConfig = {
...rest of config
transpilePackages: ['@octokit/core']
...
}
module.exports = nextConfig

And that works fine.