octacian / advschem Goto Github PK

I noticed that the border has a selection box which can be pointed at and punched and even destroyed by punching and other forms of damage.

Possible solution:

• Zero-out the selection box to prevent pointing
• Add the entity to the armor group immortal=1 after spawning

“Probability is a number between 0 and 127”.

This is false, it must be between 0 and 255.

I have tried several times to save a schematic with nodes of probability = 0, but I often failed.

When I want to place the schematic again, it often happened that the nodes in question are actually placed with maximum probability (255).
It seems to happen more likely after I worked with many schematics in succession.
And just to be sure, I also restarted Minetest between every save and loading attempt.

What I did:

• Placed the thing I want so save
• Used a glass node and set probability 0 for it
• Placed said glass node everywhere where I do not want to overwrite nodes
• Select region, entered name and saved
• Restart Minetest and placed the schematic with /placeschem

If I was lucky, the glass nodes should now have disappered.
But if I was unlucky, the glass nodes are still there.

This bug breaks a key use case of this mod, sadly. :-(

The border around the schematic has a problem, if it touches a solid node, there are some Z-fighting issues.

I think this can be solved by making sure the border is very slightly larger than the selected area.

Add node with guaranteed probability = 0.
I suggest you add a node with an guaranteed probability of 0.

This should be an invisible (or at least barely visible),pointable, instantly minable, non-walkable, non-explodable node with a small selection box (maybe 1/5). If this node is saved into a schematic, the probability will always be 0, meaning that the schematic keeps the target node unchanged when placed.

If this node is placed into the schemtic tab, it gets rejected because the point of this node is to have a forced probability of 0.

I think such a feature is quite essential because I often want schematics to not overwrite exsiting nodes, not even with air. One use case is a room where you want the interiour to be filled with air, but leave the exteriour mostly alone.

Based on my thoughts here:

https://forum.minetest.net/viewtopic.php?f=47&t=15272&view=unread#p288670