cliUx.ux.flush timeout throws after 10 seconds with `Error: timed out` about core

[mdonnalley]

@codespool The change that went into 1.9.7 actually fixed the flush functionality. The issue in oclif/oclif#922 was that we weren't awaiting a promise and fixing flush revealed that. You can see the fix here: oclif/oclif#926

I'm assuming that you have a similar issue with your command

[codespool]

You could wrap spawn in a promise, listen to exit event, and resolve when it happens. That should play nicely with oclif/core.
We are using it here:
https://github.com/AstarNetwork/swanky-cli/blob/master/src/commands/compile/index.ts

[codespool]

Ah, I see, so pre 1.9.7 tolerates the buggy code, and that's why it works..
Thanks for clearing it up!

[azmuelb]

@mdonnalley I'm not sure that's necessarily the same thing. Unless I'm mistaken, the fix applies to a generator issue in the main oclif package, but there's still an issue specifically in oclif/core. Our project is currently hitting this problem, and we're only using oclif/core.

@codespool I know you closed this, but have you checked yet whether it's actually fixed on your end?

[codespool]

Yes, as @mdonnalley hinted, the latest version works when we await the task.run() promise from listr2.

The promise.race in the flush implementation gets passed your command and a timeout of 10s, so if you don't await for a promise inside your command, and it takes more than 10s to resolve, it will throw that timed out error.

So, doesn't matter is it a yeoman generator or something else, as long as you await whatever's promise is running in your Command.run()

[azmuelb]

Ah, that makes sense, I misunderstood the root problem earlier. Maybe our case is a bit special then. We have a command that spawns a detached child process with child_process.spawn, and expects the Node process to exit while the child process continues.

So, I'm not sure if this is still a flaw in oclif not handling that scenario, or if this is just an unusual scenario that should be handled differently on our end.