obsidian-ttrpg-community / pathfinder-2e-srd-markdown Goto Github PK

Hello! First off, huge thank you to everyone involved with this project, it's quite an amazing feat.

I'm going through and making a few links to tables that I'll need for a quick reference in my campaign, and I noticed that in the alchemical-gear table (rules/tables/alchemical-gear) that 1) it doesn't link to the actual item, and 2) the items that are contained don't -technically- exist.

I am planning on fixing (1) wherever I find stated issue (I would link "Lesser acid flask" to acid-flask), and as far as (2) goes, I'm not sure how to resolve it.

In the chapter for the alchemical gear, it goes on after the table to explain each item in detail. The acid flask item detail only states that it does the "listed ... damage", which isn't much help either way. I'm thinking for items in this manner to have a few examples of "lesser", "greater", etc for quick damage references.

I'm planning on making these changes myself, but I also wanted to get some feedback on if anyone has any other ideas on how to go about fixing this, and if the community would be fine with me making a PR for it.

Thanks!

Fantasy Statblock

• Most of the Statblock links will be fixed in this release. However, those that link to a header with a space, such as [[rules/core-rulebook/chapter-9-playing-the-game.md#Difficult%20Terrain|difficult terrain]] are not being processed by the Fantasy Statblock plugin. Javalent has been made aware.

• Items without Item equivalents (such as Lesser Potions) were not linked as they do not exist in the compendium yet.

Tables

• Some table data is not being generated correctly. There is a bug report in at the TTRPG-CLI repo that will fix it.

Bugs

I see a problem or inconsistency, what do I do?

You will need to file an issue, or submit a PR with the fix. As this is a mixed vault, where you do this depends on what the problem is

• Fantasy Statblocks PF2E Layout? Report it at the Pathfinder 2E Statblocks Development repo.
• Compendium/Rules display issue? Report it to the TTRPG-CLI repo.
• Missing Data? Report it to the PF2eTools repository.

Links

I don't want the items to be in /compendium/' and rules`. What do I do?

From within Obsidian, feel free to move the files where you want them to. However, this must be done Within Obsidian to ensure that Links update properly.

We also highly recommending having Absolute Links turned on in Obsidian Settings.

Danger: If you change the links to pure Wikilinks without an absolute or relative path, you risk updating links to same-named notes within Obsidian.
For example, if you have the DnD's Ancient Black Dragon, and you move the Pathfinder Ancient Black Dragon note as a short path link, the links to the DnD Ancient Black Dragon note will update to the Pathfinder Ancient Black Dragon note.

No thanks. I hate Absolute Links.

Within Obsidian, ensure in your Obsidian Settings that your preferred link system is set up. Also ensure that "Update Links" is enabled.

1. Make a temporary folder at / (Also known as root). For this example we'll use Temp.
2. Move the folders Compendium and Rules into the /Temp/ folder, so its position within your vault is /Temp/Compendium/ and `/Temp/Rules/.
3. Wait for Obsidian to update all the links.
4. Move the folder back to /Compendium/ or your preferred location, once again, using Obsidian to do the moving.

Expected Behavior

The snippet should not affect the encounter builder table.

Current Behavior

With the snippet enabled, things get wacky.

Reproduction Steps

1. Enable the snippet from this repo
2. Have the initiative tracker plugin enabled
3. Go to the encounter builder

Any field in JSON with an identical Name to ones above it will overwrite that field, not create an additional. So an adult cloud dragon, for instance, has 4 melee attacks: jaws, claw, tail, and horn. But because all of these attacks are named "Melee," only the horn will show when the statblock renders. The attacks need to be given unique names. At least this is what I'm thinking; if I'm doing something wrong please lmk!

See Title.

In particular. Focus on:

1. Spell Names with spaces and hyphens
2. Conditions

In Obsidian's tag view, I noticed a lot of tags with only 1 reference.

Digging further, I see that there are a lot of tags in /rules/traits/index.md . I'm wondering if these were meant to link to the files in the folder rather than be turned into tags.