observerly / nocturnal Goto Github PK

Currently, the nocturnal endpoints provide the following details on e.g., https://nocturnal.observerly.com/api/v1/transit?datetime=2021-05-15T00:00:00.000Z&longitude=-155.468094&latitude=19.798484&ra=88.7929583&dec=7.4070639:

{
  "observer": {
    "datetime": "2021-05-15T00:00:00Z",
    "latitude": "19.798484",
    "longitude": "-155.468094"
  },
  "position": {
    "alt": "73.448912",
    "az": "136.917066",
    "dec": "7.407064",
    "ra": "88.792958"
  },
  "transit": {
    "rise": "2021-05-15T08:31:29-10:00",
    "set": "2021-05-15T20:50:55-10:00"
  }
}

It would be incredibly useful that we provide a range of preferred observation, close the maximum transitory altitude and at least +15° above local observer's horizon (i.e., when the object cross the observer's meridian*).

The following calculation from Meeus, Jean. 1991. Astronomical algorithms. Richmond, Va: Willmann - Bell. on p.104 will be needed:

*The observer's meridian is defined as the line which passes through the zenith and the south point on the horizon.

Currently, the nocturnal endpoints provide the following details on e.g., https://nocturnal.observerly.com/api/v1/transit?datetime=2021-05-15T00:00:00.000Z&longitude=-155.468094&latitude=19.798484&ra=88.7929583&dec=7.4070639:

{
  "observer": {
    "datetime": "2021-05-15T00:00:00Z",
    "latitude": "19.798484",
    "longitude": "-155.468094"
  },
  "position": {
    "alt": "73.448912",
    "az": "136.917066",
    "dec": "7.407064",
    "ra": "88.792958"
  },
  "transit": {
    "rise": "2021-05-15T08:31:29-10:00",
    "set": "2021-05-15T20:50:55-10:00"
  }
}

It would be incredibly useful that we provide various lunar parameters for the duration of the transit, such as the angular separation between the Moon and the object of interest as well as the average lunar illumination, determining an estimated observation quality for the given object.

When passing in a particular datetime to the API that is not 2021-05-14T00:00:00.000Z the API returns incorrect set and rise times.

The correct rise and set times are only for the 2021-05-14T00:00:00.000Z datetime passed in.

The returned date times are offset by the same amount, i.e., 6am adds 6 hours to the final maximum, rise and set times.

Endpoint: https://nocturnal.observerly.com/api/v1/transit?datetime=2022-05-15T00:00:00.000Z&longitude=-155.468094&latitude=19.798484&ra=88.7929583&dec=7.4070639

This is an issue with the downstream dusk.GetObjectRiseObjectSetTimesInUTCForDay() whereby the datetime passed in has not been normalised to the 00:00:00.000 time for the datetime given.