Coder Social home page Coder Social logo

ddr's Introduction

ddr's People

Contributors

c71n93 avatar olesiasub avatar renovate[bot] avatar rultor avatar yegor256 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

ddr's Issues

CondNodesResolver.kt:133: add method="" attribute

The puzzle 42-50a65b2b from #42 has to be resolved:

ifChild.setAttribute("line", line(node)) // @todo #42:30min add method="" attribute

The puzzle was created by @OlesiaSub on 15-Sep-22.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

qulice is not used in the build

After you fix #4, try to run mvn clean install -Pqulice and see what it says.

Also, add this -Pqulice to the build in GitHub Action

Sources.kt:84: if output directory already exists...

The puzzle 119-1e2fda85 from #119 has to be resolved:

* @todo #119:30min if output directory already exists createFile throws exception and logger prints error message. This situation should be handled correctly.

The puzzle was created by @c71n93 on 20-Jul-23.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

InnerPropagator.kt:68-69: this solution is naive,...

The puzzle 44-e067a6d7 from #44 has to be resolved:

// @todo #44:30min this solution is naive, optimize it (see commented out lines)
// while (decorators.containsValue(false)) {

The puzzle was created by Olesia Subbotina on 15-Sep-22.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Refactor launch package

Before adding some functionality to aoi (objectionary/aoi#39, objectionary/aoi#40, objectionary/aoi#41) most of the code needs to be refactored here. First of all launch package need to be refactored.

Here:

private val logger = LoggerFactory.getLogger("org.objectionary.ddr.launch.Combiner")
private val sep = File.separatorChar
val documents: MutableMap<Document, String> = mutableMapOf()

global variables are defined. documents variable is modified in functions launch and buildGraph. Then documents is used throughout the program, and also in aoi.

The functions themselves here also do too much, so decomposition is broken. I think this code should be made more object-oriented. @yegor256, @mximp, WDYT?

IntegrationDdrWorkflowBase.kt:39:...

The puzzle 121-f5932eb5 from #121 has to be resolved:

* @todo #121:60min IntegrationDdrWorkflowBase test needs to be refactored. Some decomposition needs to be added into doTest method.

The puzzle was created by c71n93 on 13-Jul-23.

Estimate: 60 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Sources.kt:85: make public field "resPath" where path to...

The puzzle 119-20740a5e from #119 has to be resolved:

* @todo #119:30min make public field "resPath" where path to result directory will be stored

The puzzle was created by @c71n93 on 20-Jul-23.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

InnerBase.kt:44: InnerBase test needs to be refactored....

The puzzle 121-755ab0e3 from #121 has to be resolved:

* @todo #121:60min InnerBase test needs to be refactored. Some decomposition needs to be added into doTest method.

The puzzle was created by @c71n93 on 13-Jul-23.

Estimate: 60 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

ResolverTest.kt:60: enable this test

The puzzle 61-6e7154c3 from #61 has to be resolved:

The puzzle was created by @OlesiaSub on 21-Sep-22.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

CondNodesResolver.kt:106: remove duplicated code

The puzzle 45-d09d96b0 from #45 has to be resolved:

// @todo #45:30min remove duplicated code

The puzzle was created by @OlesiaSub on 15-Sep-22.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

CondNodesResolver.kt:116: [igAttr] is initialized...

The puzzle 63-759de4ce from #63 has to be resolved:

// @todo #63:30min [igAttr] is initialized incorrectly now, it's required to add checks

The puzzle was created by @OlesiaSub on 23-Sep-22.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Fix `pos` attribute generation

In this example (taken from src/test/resources/integration/in/basic_cycle/basic_cycle.xmir):

[] > classA
  classB > @
  [] > doA
    stdout > @
      "A"

[] > classB
  classA > @
  [] > doBA
    ^.doA > @

XMIR listing of object classB looks like this:

<o abstract="" line="9" name="classB" pos="0">
   <o base="classA" line="10" name="@" pos="2"/>
   <o abstract="" line="11" name="doBA" pos="2">
      <o base="^" line="12" pos="4"/>
      <o base=".doA" line="12" method="" name="@" pos="5"/>
   </o>
</o>

DDR gives result transformed XMIR with such classB object (taken from src/test/resources/integration/out/basic_cycle/basic_cycle.xmir):

<o abstract="" line="9" name="classB" pos="0">
   <o base="classA" line="10" name="@" pos="2" ref="3"/>
   <o abstract="" line="11" name="doBA" pos="2">
      <o base="^" line="12" pos="4"/>
      <o base=".@" line="12" method="" pos="9"/>
      <o base=".doA" line="12" method="" name="@" pos="5"/>
   </o>
</o>

As an EO code, classB object should look like this:

[] > classB
  classA > @
  [] > doBA
    ^[email protected] > @

So pos of .@ equals "5" and pos of .doA equals "7". But this is not the case in the XMIR file.
We either need to delete thepos attribute for objects that are related to DDR working process, or handle their pos attribute correctly.

BuilderBase.kt:42: BuilderBase test needs to be...

The puzzle 121-2726af4f from #121 has to be resolved:

* @todo #121:60min BuilderBase test needs to be refactored. Some decomposition needs to be added into doTest method.

The puzzle was created by c71n93 on 13-Jul-23.

Estimate: 60 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

ResolverBase.kt:54: ResolverBase test needs to be...

The puzzle 121-473476e4 from #121 has to be resolved:

* @todo #121:60min ResolverBase test needs to be refactored. Some decomposition needs to be added into doTest method.

The puzzle was created by c71n93 on 13-Jul-23.

Estimate: 60 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

BasicDecoratorsResolver.kt:45: document better

The puzzle 43-7ea31038 from #43 has to be resolved:

The puzzle was created by Olesia Subbotina on 15-Sep-22.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Java heap space error

Right now if you look at the pom.xml file you'll see commented out code for .jar creation.
If you uncomment it - you'll see that build fails with "Java heap space" error.
I tried setting heap space like this, didn't help

<configuration>
  <argLine>-Xmx1024m</argLine>
</configuration>

We need to be able to create jar with dependencies to launch the app from console.

Combiner.kt:30: get rid of the global variable and fix...

The puzzle 108-37d99e1c from #108 has to be resolved:

* @todo #108:120min get rid of the global variable and fix all places were it was used

The puzzle was created by @c71n93 on 20-Apr-23.

Estimate: 120 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

CondNodesResolver.kt:136: remove duplicates from code

The puzzle 46-3505aef4 from #46 has to be resolved:

val ref1 = document.createAttribute("ref").apply { value = ref(igNode.fstOption[0]) } // @todo #46:30min remove duplicates from code

The puzzle was created by Olesia Subbotina on 15-Sep-22.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

CondNodesResolver.kt:75: this method should be used

The puzzle 39-308dddcb from #39 has to be resolved:

// @todo #39:30min this method should be used

The puzzle was created by @OlesiaSub on 15-Sep-22.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

CondNodesResolver.kt:49: remove extra "> @" and add one...

The puzzle 40-384e3e8f from #40 has to be resolved:

* @todo #40:30min remove extra "> @" and add one to .if

The puzzle was created by @OlesiaSub on 15-Sep-22.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

  • Update dependency org.jetbrains.dokka:dokka-maven-plugin to v1.9.20
  • Update dependency org.slf4j:slf4j-api to v2.0.16
  • Update dependency com.qulice:qulice-maven-plugin to v0.23.0
  • Update dependency commons-io:commons-io to v2.16.1
  • Update dependency org.apache.commons:commons-lang3 to v3.16.0
  • Update dependency org.apache.maven.plugins:maven-javadoc-plugin to v3.8.0
  • Update dependency org.codehaus.mojo:exec-maven-plugin to v3.4.0
  • Update dependency org.sonatype.plugins:nexus-staging-maven-plugin to v1.7.0
  • Update actions/cache action to v4
  • Update actions/setup-java action to v4
  • Update codecov/codecov-action action to v4
  • Update dependency org.apache.maven.plugins:maven-failsafe-plugin to v3
  • Update dependency org.apache.maven.plugins:maven-surefire-plugin to v3
  • Update dependency org.jetbrains:annotations to v24
  • Update dependency ubuntu to v22
  • Update kotlin monorepo to v2 (major) (org.jetbrains.kotlin:kotlin-test-junit5, org.jetbrains.kotlin:kotlin-test, org.jetbrains.kotlin:kotlin-stdlib, org.jetbrains.kotlin:kotlin-maven-plugin)
  • ๐Ÿ” Create all rate-limited PRs at once ๐Ÿ”

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

Detected dependencies

github-actions
.github/workflows/build.yml
  • actions/checkout v4
  • actions/setup-java v1
  • actions/cache v3
.github/workflows/codecov.yml
  • actions/checkout v4
  • actions/setup-java v1
  • actions/cache v3
  • codecov/codecov-action v3
  • ubuntu 20.04
.github/workflows/diktat.yml
  • actions/checkout v4
  • actions/setup-java v1
maven
pom.xml
  • com.jcabi:parent 0.64.1
  • org.apache.maven.plugins:maven-javadoc-plugin 3.6.3
  • org.sonatype.plugins:nexus-staging-maven-plugin 1.6.13
  • org.jetbrains.kotlin:kotlin-maven-plugin 1.7.21
  • org.apache.maven.plugins:maven-surefire-plugin 2.22.2
  • org.apache.maven.plugins:maven-failsafe-plugin 2.22.2
  • org.codehaus.mojo:exec-maven-plugin 3.1.1
  • org.cqfn.diktat:diktat-maven-plugin 1.2.5
  • org.jetbrains.dokka:dokka-maven-plugin 1.9.10
  • org.cactoos:cactoos 0.55.0
  • com.jcabi:jcabi-xml 0.25.5
  • com.yegor256:xsline 0.13.0
  • xml-apis:xml-apis 1.4.01
  • org.jetbrains.kotlin:kotlin-stdlib 1.7.21
  • org.jetbrains.kotlin:kotlin-test 1.7.21
  • org.jetbrains.kotlin:kotlin-test-junit5 1.7.21
  • org.junit.jupiter:junit-jupiter-engine 5.9.1
  • org.junit.jupiter:junit-jupiter-api 5.9.1
  • org.jetbrains:annotations 23.0.0
  • org.apache.commons:commons-lang3 3.14.0
  • org.slf4j:slf4j-api 2.0.11
  • ch.qos.logback:logback-classic 1.4.4
  • org.eolang:eo-parser 0.28.10
  • org.eolang:eo-maven-plugin 0.28.11
  • commons-io:commons-io 2.15.1
  • com.qulice:qulice-maven-plugin 0.22.0

  • Check this box to trigger a request for Renovate to run again on this repository

CondAttributesSetter.kt:36: remove code duplication

The puzzle 52-c90fbfaa from #52 has to be resolved:

// @todo #52:30min remove code duplication

The puzzle was created by @OlesiaSub on 19-Sep-22.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

ResolverTest.kt:51: enable by processing @ as well. Plus,...

The puzzle 47-62e09889 from #47 has to be resolved:

// @todo #47:30min enable by processing @ as well. Plus, enable the condition test

The puzzle was created by Olesia Subbotina on 15-Sep-22.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

InnerPropagator.kt:65-66: this solution is naive,...

The puzzle 44-d7056616 from #44 has to be resolved:

* @todo #44:30min this solution is naive, optimize it (see snippet below)
* while (decorators.containsValue(false)) { ... }

The puzzle was created by @rultor on 09-Mar-23.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

AttrBase.kt:43: AttrBase test needs to be refactored....

The puzzle 121-c98915f6 from #121 has to be resolved:

* @todo #121:60min AttrBase test needs to be refactored. Some decomposition needs to be added into doTest method.

The puzzle was created by @c71n93 on 13-Jul-23.

Estimate: 60 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Refactor GraphBuilder class

Issue #116 depends on GraphBuilder class. This class not suitable for changes now: lack of documentation and non-scalable code style. So, first of all, it is necessary to refactor GraphBuilder.

CondNodesResolver.kt:41: the code here needs refactoring...

The puzzle 41-51bb4399 from #41 has to be resolved:

* @todo #41:30min the code here needs refactoring and documentation

The puzzle was created by @OlesiaSub on 15-Sep-22.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

LaunchDdr.kt:12: implement launcher class

The puzzle 108-df904ef6 from #108 has to be resolved:

* @todo #108:120min implement launcher class

The puzzle was created by @c71n93 on 16-Mar-23.

Estimate: 120 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

CondNodesResolver.kt:44-46: right now conditions are set...

The puzzle 64-d0e97ec0 from #64 has to be resolved:

* @todo #64:30min right now conditions are set absolutely equivalent to how they looked initially,
* but their initial parameters need to be replaced by the parameters they were initialized with,
* see conditional attribute test expected output, it's incorrect now

The puzzle was created by @OlesiaSub on 23-Sep-22.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

GraphBuilder.kt:144-146: Current algorithm of finding...

The puzzle 115-d5eab858 from #115 has to be resolved:

* @todo #115:90m/DEV Current algorithm of finding graph heads is very inefficient and requires refactoring.
* To reimplement `setHeads()`, `findHeadsExcessively()` and `thinOutHeads()` functions.
* To reimplement all functions from `ClosedCycleProcessor.kt`.

The puzzle was created by @c71n93 on 21-Sep-23.

Estimate: 90 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Nodes.kt:52-53: gather cond, fstOption and sndOption into...

The puzzle 64-1a042343 from #64 has to be resolved:

* @todo #64:30min gather cond, fstOption and sndOption into the existing
* IgNodeCondition structure and refactor its usages

The puzzle was created by @OlesiaSub on 03-Oct-22.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.