objectionary / aoi2

This is our web site, it's here: objectionary.com

aoi2's Issues

Qulice dependency problems

Running mvn install with -Pqulice gives an error:

[WARNING] Unused declared dependencies found:
        jpl:jpl:jar:7.4.0:compile
        org.jetbrains.kotlin:kotlin-stdlib-jdk8:jar:1.7.10:compile
[WARNING] Used undeclared dependencies found:
        org.jetbrains.kotlin:kotlin-test:jar:1.7.21:compile
        commons-io:commons-io:jar:2.11.0:compile
        org.slf4j:slf4j-api:jar:2.0.4:compile
        org.jetbrains:annotations:jar:23.0.0:compile
        xml-apis:xml-apis:jar:1.4.01:compile
        org.jetbrains.kotlin:kotlin-stdlib:jar:1.7.21:compile
        org.junit.jupiter:junit-jupiter-api:jar:5.9.1:test
        com.yegor256:xsline:jar:0.13.0:compile
[INFO] You can suppress this message by <exclude>dependencies:...</exclude> in pom.xml, where <...> is what the dependency name starts with (not a regular expression!)
[INFO] Read our quality policy: http://www.qulice.com/quality.html
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  18.298 s
[INFO] Finished at: 2023-02-18T16:45:36+03:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.qulice:qulice-maven-plugin:0.22.0:check (jcabi-qulice-check) on project aoi2: Failure: 10 dependency problem(s) found -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal com.qulice:qulice-maven-plugin:0.22.0:check (jcabi-qulice-check) on project aoi2: Failure
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:347)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:330)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:213)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:175)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:76)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:163)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:160)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:568)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
Caused by: org.apache.maven.plugin.MojoFailureException: Failure
    at com.qulice.maven.CheckMojo.doExecute (CheckMojo.java:85)
    at com.qulice.maven.AbstractQuliceMojo.execute (AbstractQuliceMojo.java:170)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:342)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:330)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:213)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:175)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:76)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:163)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:160)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:568)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
Caused by: com.qulice.spi.ValidationException: 10 dependency problem(s) found
    at com.qulice.maven.DependenciesValidator.validate (DependenciesValidator.java:109)
    at com.qulice.maven.CheckMojo.run (CheckMojo.java:149)
    at com.qulice.maven.CheckMojo.doExecute (CheckMojo.java:79)
    at com.qulice.maven.AbstractQuliceMojo.execute (AbstractQuliceMojo.java:170)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:126)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:342)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute (MojoExecutor.java:330)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:213)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:175)
    at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 (MojoExecutor.java:76)
    at org.apache.maven.lifecycle.internal.MojoExecutor$1.run (MojoExecutor.java:163)
    at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute (DefaultMojosExecutionStrategy.java:39)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:160)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:105)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:73)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:53)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:118)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:568)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

There are 10 dependency problem, that need to be fixed.

PlGenerator.kt:139: this method is not used here; also it...

The puzzle 22-12722703 from #22 has to be resolved:

aoi2/src/main/kotlin/org/objectionary/aoi/generate/PlGenerator.kt

Line 139 in f561921

* @todo #22 this method is not used here; also it defined at SourceExtractor

The puzzle was created by @rultor on 02-Mar-23.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency org.slf4j:slf4j-api to v2.0.13
• Update dependency com.jcabi:jcabi-xml to v0.29.0
• Update dependency com.jcabi:parent to v0.67.0
• Update dependency com.qulice:qulice-maven-plugin to v0.23.0
• Update dependency com.yegor256:xsline to v0.21.1
• Update dependency org.eolang:eo-parser to v0.38.4
• Update junit5 monorepo to v5.10.3 (org.junit.jupiter:junit-jupiter-api, org.junit.jupiter:junit-jupiter-engine)
• Update dependency org.codehaus.mojo:exec-maven-plugin to v3
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

maven

pom.xml

• com.jcabi:parent 0.63.2
• org.jetbrains.kotlin:kotlin-maven-plugin 2.0.0
• org.apache.maven.plugins:maven-surefire-plugin 3.3.0
• org.apache.maven.plugins:maven-failsafe-plugin 3.3.0
• org.codehaus.mojo:exec-maven-plugin 1.6.0
• org.eolang:eo-parser 0.28.10
• org.eolang:deog 0.0.4
• com.jcabi:jcabi-xml 0.25.5
• com.yegor256:xsline 0.13.0
• org.jetbrains.kotlin:kotlin-test-junit5 2.0.0
• org.jetbrains.kotlin:kotlin-test 2.0.0
• org.jetbrains.kotlin:kotlin-stdlib 2.0.0
• org.jetbrains:annotations 24.1.0
• org.junit.jupiter:junit-jupiter-engine 5.8.2
• commons-io:commons-io 2.16.1
• org.slf4j:slf4j-api 2.0.11
• xml-apis:xml-apis 2.0.2
• org.junit.jupiter:junit-jupiter-api 5.9.1
• com.qulice:qulice-maven-plugin 0.22.0

---

• Check this box to trigger a request for Renovate to run again on this repository

Add unit tests

There are no unit tests at all. Some need to be added after completing #19.

Document the code

Code need to be fully or partially documented.

Fix integration test reference output

Fix reference output for integration test (file src/test/resources/integration/out/basic). The program from which this output is generated looks like this:

cat
  [] > talk
    QQ.io.stdout > @
      "Meow!"
  [dir] > move
    QQ.io.stdout > @
      dir

[] > dog
  [] > talk
    QQ.io.stdout > @
      "Woof!"
  [dir] > move
    QQ.io.stdout > @
      dir
  [] > smth
    QQ.io.stdout > @
      "smth"

[x y] > some_object
  y.talk > @

[x] > other_object
  x.smth > @

[] > app
  some_object dog > so
  so > @

Current reference output declares that result of AOI analysis should look like this:

 <aoi>
    <obj name="cat">
       <inferred>
          <obj name="move"/>
       </inferred>
    </obj>
    <obj name="talk">
       <inferred>
          <obj name="smth"/>
       </inferred>
    </obj>
 </aoi>

but in fact it should look like this (taken from aoi repository):

 <aoi>
    <obj fqn="some_object.x">
       <inferred>
          <obj fqn="cat"/>
          <obj fqn="dog"/>
       </inferred>
    </obj>
    <obj fqn="other_object.x">
       <inferred>
          <obj fqn="dog"/>
       </inferred>
    </obj>
 </aoi>

The problem is, that it test is passed now. So, first, we need to make AOI produce the correct result.

configure github actions

PlGenerator.kt:16: this global constant need to be removed

The puzzle 22-09150626 from #22 has to be resolved:

aoi2/src/main/kotlin/org/objectionary/aoi/generate/PlGenerator.kt

Line 16 in f561921

* @todo #22 this global constant need to be removed

The puzzle was created by @rultor on 02-Mar-23.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Add README

I think we need to add README to this repository.

PlGenerator.kt:47: this piece of code (5 lines below) do...

The puzzle 22-3ef54865 from #22 has to be resolved:

aoi2/src/main/kotlin/org/objectionary/aoi/generate/PlGenerator.kt

Line 47 in f561921

* @todo #22 this piece of code (5 lines below) do nothing

The puzzle was created by @rultor on 02-Mar-23.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

PlGenerator.kt:72: refactor this method (too much nesting)

The puzzle 22-a4c0b55e from #22 has to be resolved:

aoi2/src/main/kotlin/org/objectionary/aoi/generate/PlGenerator.kt

Line 72 in f561921

* @todo #22 refactor this method (too much nesting)

The puzzle was created by @rultor on 02-Mar-23.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Add target directory to .gitignore

The target directory needs to be removed from the repository.

PrologFileWriter.kt:8: write them to file

The puzzle 22-90745655 from #22 has to be resolved:

aoi2/src/main/kotlin/org/objectionary/aoi/generate/util/PrologFileWriter.kt

Line 8 in f561921

* @todo #22 write them to file

The puzzle was created by @rultor on 02-Mar-23.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Refactor all the code

The code needs refactoring. Check #21 (comment)