Coder Social home page Coder Social logo

es5-polyfill's People

Contributors

luckyadam avatar yuche avatar

Stargazers

avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

bkh2js liangzhien faker-a chenhaiwei webppei yyfullstack semlaw trollcus fzliang dahuahe soluteli kaihuatech titanhope listenecho

es5-polyfill's Issues

Missing global attributes in IE9

IE9 have all four attributes and pass the following test, but it shouldn't because it doesn't have scrollX and scrollY.

es5-polyfill/dist/polyfill.js

Lines 1119 to 1121 in 3f186b5

if ('innerWidth' in global && 'innerHeight' in global && 'pageXOffset' in global && 'pageYOffset' in global) {
return;
}

According to this snippet, the polyfill complete six global attributes instead of four. I suggest we test all attributes it affected to make IE9 environment more flat.

es5-polyfill/dist/polyfill.js

Lines 1134 to 1157 in 3f186b5

Object.defineProperties(global, {
innerWidth: {
get: function () {
return docEl.clientWidth;
}
},
innerHeight: {
get: function () {
return docEl.clientHeight;
}
},
pageXOffset: {
get: scrollX
},
pageYOffset: {
get: scrollY
},
scrollX: {
get: scrollX
},
scrollY: {
get: scrollY
}
});

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.