nypl-publicdomain / data-and-utilities Goto Github PK

The note field in each JSON object is an array of objects, like so:

  "UUID": "5db7ad80-c52a-012f-0a4c-3c075448cc4b",
  "databaseID": 3012441,
  "note": [
    {
      "type": "content",
      "text": "California shown as an island."
    },
    {
      "type": "content",
      "text": "Includes decorative cartouche showing native North Americans and ill. of animals in the body of the map."
    }
...

The current documentation incorrectly describes this field as an array of strings.

Is there a set update schedule for these data? It would be helpful to have some note in the README file as to how often new/revised data will be committed to the repository (monthly? quarterly? "periodically"? etc.) (please for goodness sake, try to have the answer not be "periodically" 😝)

Thanks for posting all these data! 🎆 👍 😆 🔢

So, do you have a pull request policy?

Since the data here are (presumably) generated from your internal collections management system, the usual pull request system may not work, as you would want to effect changes to either the content or presentation of these data in the upstream CMS and/or export scripts. If you want all suggestions to go through the link you provided, you might consider having a heading within your README.md on Pull Requests reiterating that. Similarly, if you would accept PRs for the documentation in the README itself, or to include new script examples, consider saying so explicitly (see the Carnegie Museum docs).

I'm playing with the data you shared and found some data entry issues I think. The start date for the items 4257398 and 4257398 show as "4154".

like so:

### License

See [license](/LICENSE).

I am trying to use the NYPL DIgital Collections API in an Alexa Skill I am building. This skill searches what a user says over the public domain and returns an item image in a card inside the Alexa app. Amazon requires that the server hosting the images should be CORS-enabled. Right now I have trouble displaying the images using the image links provided in the API response. Is the NYPL image server CORS enabled?