nxp-qoriq / cst Goto Github PK

When compiling this tool using the default -Werror flag, the compiler throws deprecated-declarations errors. For example:

common/crypto_utils.c:159:9: error: 'RSA_sign' is deprecated: Since OpenSSL 3.0 [-Werror=deprecated-declarations]
  159 |         ret = RSA_sign(NID_sha256, img_hash, len,
      |         ^~~
In file included from /usr/include/openssl/x509.h:36,
                 from /usr/include/openssl/ssl.h:31,
                 from common/crypto_utils.c:37:
/usr/include/openssl/rsa.h:353:27: note: declared here
  353 | OSSL_DEPRECATEDIN_3_0 int RSA_sign(int type, const unsigned char *m,
      |                           ^~~~~~~~

In downstream uses of CST, such as meta-freescale, those warnings/errors are just suppressed by appending -Wno-deprecated-declarations to the CFLAGS. This is also the proposed solution in #2.

I'm not a huge fan of this as it just puts a Band-Aid over a time bomb. When the deprecated calls finally get removed, there will be pressure to just continue using an insecure, older version of OpenSSL with the deprecated functions. This is a very bad idea considering this is the basis of code signing and secure boot implementations for various critical embedded systems. OpenSSL must stay up to date in these devices to prevent vulnerabilities and hacks.

I'm currently working on updating the crypto_* calls using the updated EVP API and will submit a PR for it when it's ready. I could definitely use some help testing it.