Coder Social home page Coder Social logo

dispatch's People

Contributors

nut-code-monkey avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

dispatch's Issues

About condition usage

I thinks, condition.notify_one() must be call in mutex lock scope. Why you try to avoid it?
(usage reference :http://en.cppreference.com/w/cpp/thread/condition_variable)

void thread_pool::push_task_with_priority(const dispatch::function& task, queue::priority priority) {
    {
        std::unique_lock<std::mutex> lock(mutex);

        auto queue = queues[priority];
        if (!queue) {
            queue = std::make_shared<queue_impl>(priority);
            queues[priority] = queue;
        }
        
        queue->tasks.push(task);
        
        unsigned max_number_of_threads = std::max<unsigned>(std::thread::hardware_concurrency(), 2);
        unsigned number_of_threads_required = round(log(queues.size()) + 1);
        while (threads.size() < std::min<unsigned>(max_number_of_threads, number_of_threads_required)) {
            add_worker();
        }
    }
    condition.notify_one();
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.