Coder Social home page Coder Social logo

games's People

Contributors

feynmandna avatar mkoth avatar walkwel avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

games's Issues

Click on head to head match - should be handled properly.

Users can click on the result of any head-to-head match to play a given bot as player 1 or player 2.

Currently, this is achieved by href on A tag. There needs to be a method pass to the element from the parent component that will be responsible to re-render the game with selected controls.

Refer to this code
https://github.com/NUS-ALSET/games/blob/master/src/squadSinglePlayerGame/src/simulation/table-result.js#L94

https://github.com/NUS-ALSET/games/blob/master/src/squadSinglePlayerGame/src/simulation/table-result.js#L100

Provide custom code for all 3 levels in props

https://github.com/NUS-ALSET/games/blob/master/src/squadSinglePlayerGame/src/simulation/level1.js
https://github.com/NUS-ALSET/games/blob/master/src/squadSinglePlayerGame/src/simulation/level2.js
https://github.com/NUS-ALSET/games/blob/master/src/squadSinglePlayerGame/src/simulation/level3.js

These 3 are the custom codes that user will write and can able to edit according to me so instead of providing fixed code and importing in the main component, provide an option to pass these 3 level code as props so that user can edit them in different code editor and that can be used in this component via props.

ES Lint Issues

There is so many ES Lint issue in the repo. It is important to fix them all before integrating them into the main project. Kindly have a look at the screenshot. The console needs to be clear when you start the project.

The screenshot is of Passenger Pickup game.

screenshot 2018-10-04 at 6 08 29 pm

Passenger PickUp game UI suggestions

  1. make empty taxi display green
  2. make occupied taxi display red with passenger label, eg A, B, C...
  3. label both the passengers and their destinations to be same as the label as the passenger in an occupied taxi, like A, B, C...
  4. change the grass tile to represent city landscape

visual "paper-prototype":
image
image

image

The priority is to make the game's mechanics more apparent and clear to the player. It does not have to be pretty :)

separate All the styles in the css file so that it can override

All the elements have position absolute which makes it difficult to integrate into other designs. Put all the styles into separate CSS file so that they can be overridable to integrate. Below is an example is given for Tournament.js file

Instead of this
<div style={{position:'absolute', zIndex:100, left:'50%', transform:'translate(-50%, 0%)', top:'145px'}}>

Use It as
<div className="tournament__container">

and styles will goes into tournament.css file or style.css

style.css

.tournament__container{
  position: absolute;
   zIndex:100;
  left:50%;
  transform:translate(-50%, 0%);
}

this file can be imported into react component directly.

At Achievements, Failed to Compile

image
./src/components/games/passenger-picker/src/view/updater.js
Attempted import error: '../simulation/simulation' does not contain a default export (imported as 'Simulation').

Tournament Table Click BotvsBot should launch a Spectator mode

image

Currently clicking the bot-vs-bot cell re-arranges the table cells, (is it simulating the whole tournament again?).

Please implement the spectator mode for bot-vs-bot match when click bot-vs-bot cell:
image
NOTE: spectator mode for bot-vs-bot has no code editor below

Export components instead of Render

Game components are being rendered directly using React-DOM for codesandbox but we need to make a way to export a component also so that It can be integrated with other apps.

Props required for tournament customization

Run Tournament
Custom Code Tournament
Hide Tournament

buttons need to be passed as props to the Tournament component so that they can be controllable and customizable from the parent component.

Example:
RunTournament: True/False
CustomCodeTournament: True/False
HideTournament: True/False

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.