nullx002 / eidogo Goto Github PK

Clicking "Download SGF" sends the SGF data as mime-type plain/text. It
should be application/x-go-sgf.

I've attached a simple patch with the appropriate change.

What steps will reproduce the problem?
1. Use the Sensei's Library diagram generator to create a diagram without
all 4 borders (like most problem diagrams). For example,
http://www.godiscussions.com/sgf/march2008/h9H3uUVoRYnJYFg16GRMTLBvXifKzmgg.sgf
2. Open it in EidoGo, like
http://eidogo.com/#url:http://www.godiscussions.com/sgf/march2008/h9H3uUVoRYnJYF
g16GRMTLBvXifKzmgg.sgf
3. The stones are rendered but there is no board behind any of it -- they
are just hanging in space. Making moves is impossible.

Not sure if this is a known missing feature or a new bug, but I thought I'd
report it :)

1. Resize the window to smaller than the board size
2. click a move on the board

It is expected that the move would be played to where you click.  What
happens is that the move is played several intersections to the left


windows xp, firefox.  i used the eidogo extension for firefox, but i bet
this would happen w/o it.

Tried to use eidogo but it has problems with 7x7 and 11x 11 go (And i guess
other non standard board sizes. 

What steps will reproduce the problem?
(example)
1. go to Dragon go server
2. go to games (on the left)
3. In size tyope the strange size (whatever) 
4. Press search
5 select any of the games

What is the expected output? What do you see instead?
It becomes an 19 x19 board.

Still a very good program.


What version of the product are you using? On what operating system?

Windows XP sp2
firefox 3.5.7
eidogo 1.2
Please provide any additional information below.

This is a feature request, not an 'issue', but I hope it belongs here.

I use EidoGo often to look at positions posted on GoDiscussions and
Sensei's Library. The chief way of communicating positions on those sites
is through ASCII diagrams that the site's software converts to images.
However, there is currently no way to get EidoGo to produce a compliant
ASCII diagram, requiring the user to instead perform the laborious process
of drawing it by hand, or using something like glGo to export to ASCII.

I propose a new button, perhaps under the "Save to Server" and "Download to
SGF" buttons, that says "Export to ASCII" which automatically saves an
ASCII diagram of the currently-displayed board position to the user's
clipboard, or (if that's not possible... does Javascript have clipboard
access?) at least to a text field that the user can manually copy+paste from.

I think this feature is useful in enough scenarios that it is worth the
extra little bit of UI clutter.

I would be willing to try to implement this feature myself (I've been
actually looking for a chance to help out with EidoGo if I can...) so if
Justin just confirms that such a patch would be accepted if written, I'd
get to work on it ASAP.

What steps will reproduce the problem?
1. Launch Eido go using Firefox extension to open an SGF file
2. Select "Score Estimate"

What is the expected output? What do you see instead?
Expected: Scored board and net score to be displayed.
Actual: A little clock quickly appears and goes away in the Variations
window, nothing else changes

What version of the product are you using? On what operating system?
Running from http://eidogo.com/ site on Windows XP using Firefox 3.0.1

Please provide any additional information below.

Sometimes, in some browsers (particularly Firefox 3.5 and newer versions of
Safari), stones will either be missing or invisible.

The problem happens because when the player.css stylesheet is loaded, the
browser may do so asynchronously. This creates a race condition where
sometimes the board renderer's constructor runs before the stylesheet has
finished loading. Because the styles haven't loaded, it incorrectly
calculates the sizes of stones and positions them incorrectly.

There isn't a straightforward way to be sure the stylesheet has loaded
(other than polling some element's styles until they change), but a simple
workaround is to explicitly load player.css in the header of the page
rather than relying on it being loaded by javascript.

What steps will reproduce the problem?
1. I've uploaded a game that exhibits this problem: URL: 
http://eidogo.com/#2D0ZOjr5
2. Skip to the last move (White pass)
3. Press 'score estimate'

What is the expected output? What do you see instead?
There is a group of black stones in the centre of the board which are 
incorrectly marked as dead even though they are connected to a live group. The 
black stones in this chain which border on to open territory are marked as live 
(OK), where as the stones that are bordered only by other stones are marked as 
dead (Not ok.)

The score estimate is incorrect as a result because the incorrectly marked 
stones are counted as white's territory and captures. Score (incorrect): 'White 
wins by 12 points'. Correct score would be 'Black wins by 2 points'

Hopefully you will be able to reproduce this and see the problem for yourself.

What version of the product are you using? On what operating system?

The version currently on the http://eidogo.com website. I'm currently using 
Firefox 3.6.9 on Ubuntu 10.04 LTS - Lucid Lynx.

Please provide any additional information below.

If black passes (Press pass button in Eidogo) before pressing 'Score estimate' 
then the game is scored correctly and black wins by 2 points.

If you page through search results, it shows games 1-50, then 52-101,
103-152, etc. instead of 1-50, 51-100, 101-150, etc.

I've attached a simple patch to correct the behaviour.

In problem mode, if a problem is up against the bottom and/or right edges
of the board, too much padding will get added to the top and/or left sides.
Also, if the game tree contains a pass the size can get completely screwed up.

I've attached a patch to correct both problems.

It would be usefull with a function to toggle full screen, or perhaps just a 
big overlay x% of window size. Some games with a lot of comments would be 
easier to read. Also - it would look quite nice!

I'm not sure if this is a bug or a known thing, but basically I've
discovered while in the process of coding on EidoGo that it doesn't like
being anywhere except in Apache's root directory.

What steps will reproduce the problem?
1. Copy eidogo/ to an Apache directory other than the root. For instance,
on OS X 10.5, the root is ~/Sites. So, put eidogo/ in ~/Sites/eidogo/
2. Open http://localhost/yourname/eidogo/#blank
3. Click on "Games", for instance, to navigate away from the index.phtml page.
4. Once there, click on, say, "Blank Board".

You would expect to get taken back to http://localhost/user/eidogo/#blank.
But instead it tries to go to http://localhost/#blank, which of course is
something else entirely. Thus we get a 404.

I'm not sure if this is an intentional thing, but I hope not because that
makes developing on OS X a bit of a pain since the root Apache directory
requires the sudo password on every write. :(

Letter "I" is missing in the horizontal coords. the coords should be from A
to  S. not A to T.

I think display number is a very useful function, can you add it?

What steps will reproduce the problem?
1. Create a new SGF and put some moves on it
2. Mark an empty point at some part of the tree with a triangle
3. Create a new variation from that same position that starts at the
triangled point
4. Revisit the parent branch at the move right before the variation

Where the triangle markup should be there is now a text label literally
writing out the word "triangle" (and obscuring adjacent points in the process).