Coder Social home page Coder Social logo

Comments (3)

nturley avatar nturley commented on May 18, 2024

This is what it looks like without removing dummy edges
Screen Shot 2019-04-07 at 8 33 35 AM

This is what ELK returned

    {
      "id": "e2",
      "source": "$d_0",
      "sourcePort": "$d_0.p",
      "target": "o1",
      "targetPort": "o1.A",
      "sections": [
        {
          "id": "e2_s0",
          "startPoint": {
            "x": 214,
            "y": 32
          },
          "endPoint": {
            "x": 249,
            "y": 162
          },
          "bendPoints": [
            {
              "x": 224,
              "y": 32
            },
            {
              "x": 224,
              "y": 162
            }
          ]
        }
      ],
      "junctionPoints": [
        {
          "x": 224,
          "y": 32
        }
      ]
    },
    {
      "id": "e3",
      "source": "$d_0",
      "sourcePort": "$d_0.p",
      "target": "o2",
      "targetPort": "o2.A",
      "sections": [
        {
          "id": "e3_s0",
          "startPoint": {
            "x": 214,
            "y": 32
          },
          "endPoint": {
            "x": 249,
            "y": 97
          },
          "bendPoints": [
            {
              "x": 224,
              "y": 32
            },
            {
              "x": 224,
              "y": 97
            }
          ]
        }
      ],
      "junctionPoints": [
        {
          "x": 224,
          "y": 97
        }
      ]
    },
    {
      "id": "e4",
      "source": "$d_0",
      "sourcePort": "$d_0.p",
      "target": "o3",
      "targetPort": "o3.A",
      "sections": [
        {
          "id": "e4_s0",
          "startPoint": {
            "x": 214,
            "y": 32
          },
          "endPoint": {
            "x": 249,
            "y": 32
          }
        }
      ]
    },
    {
      "id": "e5",
      "source": "i0",
      "sourcePort": "i0.Y",
      "target": "$d_1",
      "targetPort": "$d_1.p",
      "sections": [
        {
          "id": "e5_s0",
          "startPoint": {
            "x": 159,
            "y": 162
          },
          "endPoint": {
            "x": 202,
            "y": 97
          },
          "bendPoints": [
            {
              "x": 177,
              "y": 162
            },
            {
              "x": 177,
              "y": 97
            }
          ]
        }
      ]
    },
    {
      "id": "e6",
      "source": "i1",
      "sourcePort": "i1.Y",
      "target": "$d_1",
      "targetPort": "$d_1.p",
      "sections": [
        {
          "id": "e6_s0",
          "startPoint": {
            "x": 159,
            "y": 97
          },
          "endPoint": {
            "x": 202,
            "y": 97
          }
        }
      ]
    },
    {
      "id": "e7",
      "source": "i4",
      "sourcePort": "i4.Y",
      "target": "$d_1",
      "targetPort": "$d_1.p",
      "sections": [
        {
          "id": "e7_s0",
          "startPoint": {
            "x": 159,
            "y": 32
          },
          "endPoint": {
            "x": 202,
            "y": 97
          },
          "bendPoints": [
            {
              "x": 177,
              "y": 32
            },
            {
              "x": 177,
              "y": 97
            }
          ]
        }
      ],
      "junctionPoints": [
        {
          "x": 177,
          "y": 97
        }
      ]
    }

this was the result of remove dummy edges
    {
      "id": "e2",
      "source": "$d_0",
      "sourcePort": "$d_0.p",
      "target": "o1",
      "targetPort": "o1.A",
      "sections": [
        {
          "id": "e2_s0",
          "startPoint": {
            "x": 224,
            "y": 32
          },
          "endPoint": {
            "x": 249,
            "y": 162
          },
          "bendPoints": [
            {
              "x": 224,
              "y": 162
            }
          ]
        }
      ],
      "junctionPoints": [
        {
          "x": 224,
          "y": 32
        }
      ]
    },
    {
      "id": "e3",
      "source": "$d_0",
      "sourcePort": "$d_0.p",
      "target": "o2",
      "targetPort": "o2.A",
      "sections": [
        {
          "id": "e3_s0",
          "startPoint": {
            "x": 224,
            "y": 32
          },
          "endPoint": {
            "x": 249,
            "y": 97
          },
          "bendPoints": [
            {
              "x": 224,
              "y": 97
            }
          ]
        }
      ],
      "junctionPoints": [
        {
          "x": 224,
          "y": 97
        }
      ]
    },
    {
      "id": "e4",
      "source": "$d_0",
      "sourcePort": "$d_0.p",
      "target": "o3",
      "targetPort": "o3.A",
      "sections": [
        {
          "id": "e4_s0",
          "startPoint": {
            "x": 249,
            "y": 32
          },
          "endPoint": {
            "x": 249,
            "y": 32
          },
          "bendPoints": []
        }
      ]
    },
    {
      "id": "e5",
      "source": "i0",
      "sourcePort": "i0.Y",
      "target": "$d_1",
      "targetPort": "$d_1.p",
      "sections": [
        {
          "id": "e5_s0",
          "startPoint": {
            "x": 202,
            "y": 97
          },
          "endPoint": {
            "x": 202,
            "y": 97
          },
          "bendPoints": []
        }
      ]
    },
    {
      "id": "e6",
      "source": "i1",
      "sourcePort": "i1.Y",
      "target": "$d_1",
      "targetPort": "$d_1.p",
      "sections": [
        {
          "id": "e6_s0",
          "startPoint": {
            "x": 202,
            "y": 97
          },
          "endPoint": {
            "x": 202,
            "y": 97
          },
          "bendPoints": []
        }
      ]
    },
    {
      "id": "e7",
      "source": "i4",
      "sourcePort": "i4.Y",
      "target": "$d_1",
      "targetPort": "$d_1.p",
      "sections": [
        {
          "id": "e7_s0",
          "startPoint": {
            "x": 159,
            "y": 32
          },
          "endPoint": {
            "x": 177,
            "y": 97
          },
          "bendPoints": [
            {
              "x": 177,
              "y": 32
            }
          ]
        }
      ],
      "junctionPoints": [
        {
          "x": 177,
          "y": 97
        }
      ]
    }

from netlistsvg.

nturley avatar nturley commented on May 18, 2024

I added a unit test so the build will fail until I fix this issue.

from netlistsvg.

nturley avatar nturley commented on May 18, 2024

I have a partial fix in that seems to pass the unit test, but it still leaves an extra junction in some cases. I'll add another unit test to fail when there's an extra junction.

from netlistsvg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.