ntueelightdance / lightdance-rpi Goto Github PK

Is your feature request related to a problem? Please describe.
Test Receiver in C++

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.

Currently, controller cannot parse control.json.

Describe the solution you'd like

Use binary search.

Describe alternatives you've considered

None

Additional context

None

Is your feature request related to a problem? Please describe.
For tidy code and lazy developers.

Describe the solution you'd like
isort for import sort
black for coding style

Describe alternatives you've considered
No

Additional context

Add pull request template for LightDance-RPi.

Is your feature request related to a problem? Please describe.

There are still some TODOs in rpiMgr, finish those.

Describe the solution you'd like

Reference code from last year

Describe alternatives you've considered

None

Additional context

None

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Change MAX_BRIGHTNESS (gamma_correction.cpp)
Change theta in OFrgba2rgbiref (OFrgba_to_rgb.hpp)

Describe alternatives you've considered

None

Additional context

Add pull request template for LightDance-RPi.

Is your feature request related to a problem? Please describe.
New Methods for Hardware Team Demand

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.
RPi Setup

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.
Auto Start

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.

It's too slow to wait for the response from the backend server.

We first modify the cache.

If you do something which is wrong, please refresh the web page. Backend will be right.

Describe the solution you'd like

client.cache.modify first, and update again through subscription.

Describe alternatives you've considered

ADD function is a problem. We cannot predict the added ID.

Additional context

Is your feature request related to a problem? Please describe.
add directory support at load

1. All black / All Light (frontend as well)
2. LED test : channel(int) colorCode(int) alpha(int) / partName(string) colorCode(int) alpha(int)
3. OF test : channel(int) colorCode(int) alpha(int) / partName(string) colorCode(int) alpha(int)
4. SetOFChannel(string partName, int channel)
5. SetLEDChannel(string partName, int channel)
6. partTraversalTest (frontend as well)

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.

Wire connection for play.

Describe the solution you'd like

Python

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.

Current led player will cause error due to led frame num less than 2.

Describe the solution you'd like

None

Describe alternatives you've considered

None

Additional context

None

Is your feature request related to a problem? Please describe.
Update requirements.txt

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.

Set up zmq channel between controller and CLI, enables them to communicate through tcp.

Describe the solution you'd like

Use zmq.

Describe alternatives you've considered

None

Additional context

None

Is your feature request related to a problem? Please describe.

Finish all the operations used by controller.

Describe the solution you'd like

rpiMgr.h/.cpp

Describe alternatives you've considered

None

Additional context

None

Is your feature request related to a problem? Please describe.
Documentation for CLI

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Describe the bug

Remove redundant "sudo" in the script.

To Reproduce

Expected behavior

Run the script without sudos.

Screenshots

None

Additional context

None

Is your feature request related to a problem? Please describe.

Compress multiple string responses to single string responses.

Describe the solution you'd like

Use "\n".

Describe alternatives you've considered

None

Additional context

None

Is your feature request related to a problem? Please describe.

In the current controller version, if load while playing, it will cause an error.

Describe the solution you'd like

Block load while playing.

Describe alternatives you've considered

None

Additional context

None

Is your feature request related to a problem? Please describe.
Add more and modify methods.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.
Add hardware support

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.

Remove all kinds of bug

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.

Enable client socket to save led and of control file

Describe the solution you'd like

Python

Describe alternatives you've considered

None

Additional context

None

Is your feature request related to a problem? Please describe.

In of light, alpha is divided by a redundant max num.

Describe the solution you'd like

Remove it.

Describe alternatives you've considered

None

Additional context

None

Describe the bug
No pause command in CLI

To Reproduce

Expected behavior

Screenshots

Additional context

Turn the main parsing and if/else to strategy pattern.

Is your feature request related to a problem? Please describe.

Add NTP client to enable "sync" method.

Describe the solution you'd like

Python, UDP

Describe alternatives you've considered

None

Additional context

None

Describe the bug
ID Error at ELtest

At method.cpp:

else if (cmd.size() >= 3){
        int id = stoi(cmd[1]);
        mes = "Testing id: " + cmd[2];

should be:

else if (cmd.size() >= 3){
        int id = stoi(cmd[1]);
        mes = "Testing id: " + id;

To Reproduce

Expected behavior

Screenshots

Additional context

Is your feature request related to a problem? Please describe.

Connecting to editor every time and handling command with if/else is troublesome. Using a CLI via SSH can directly control RPi.

Describe the solution you'd like

cmd2 is a command line package for python.

Describe alternatives you've considered

click: native CLI

Additional context

Is your feature request related to a problem? Please describe.

Format python socket message to fit interface defined by typescript.

Describe the solution you'd like

python json

Describe alternatives you've considered

None

Additional context

None

Is your feature request related to a problem? Please describe.

Current controller cannot play again after a play.

Describe the solution you'd like

Change _startTime.

Describe alternatives you've considered

None

Additional context

None

Is your feature request related to a problem? Please describe.

Merge new hardware library.

Describe the solution you'd like

None

Describe alternatives you've considered

None

Additional context

None

Is your feature request related to a problem? Please describe.

Add argument for client.py in startClient.sh

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.
Implement commands with strategy pattern in CLI

Describe the solution you'd like
using strategy pattern

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.

Enable socket to play

Describe the solution you'd like

Python

Describe alternatives you've considered

None

Additional context

None

Add python methods that communicate with controller(cpp)

Is your feature request related to a problem? Please describe.
A simple class to send message via zmq

Describe the solution you'd like

Describe alternatives you've considered
No

Additional context
No

Is your feature request related to a problem? Please describe.

Response through ZeroMQ to CLI and socket.

Describe the solution you'd like

Use logger class and singleton.

Describe alternatives you've considered

None

Additional context

None

Is your feature request related to a problem? Please describe.
Add new feature descriptions

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.

former Rpisocket is in .js

Describe the solution you'd like

change it to .py by websocket、websocket_server、ZMQ libraries

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.
Multi Line Response at CLI

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.

Adding testing methods for OF and LED

Describe the solution you'd like

Mutation of play

Describe alternatives you've considered

None

Additional context

None

Is your feature request related to a problem? Please describe.
Add websocket in requirements.txt

Describe the solution you'd like

Describe alternatives you've considered

Additional context

Is your feature request related to a problem? Please describe.

The play method is infinite while loop, which needs an interrupt to stop it, but zmq can only send messages, so we need to turn methods into one-thread-one-method structure.

Describe the solution you'd like

Use c++ std::thread to make every method a single thread.

Describe alternatives you've considered

Signal kill, means that zmq can send interrupts.

Additional context

None

Is your feature request related to a problem? Please describe.

Play, eltest, list in controller generates zmq error.

Describe the solution you'd like

Check controller code.

Describe alternatives you've considered

None

Additional context

None

Is your feature request related to a problem? Please describe.

Add strategy pattern structure for CLI and socket usage.
Inside the mentioned code, you should use a map to contain all the functions.

Describe the solution you'd like

Strategy pattern with base method class and inheritance functions.

Describe alternatives you've considered

None.

Additional context

None.

Is your feature request related to a problem? Please describe.

Fix all kinds of LED error.

Describe the solution you'd like

None

Describe alternatives you've considered

None

Additional context

None

Is your feature request related to a problem? Please describe.
CLI Handle Responses from Controller

Describe the solution you'd like

Describe alternatives you've considered

Additional context