nschum / full-ack Goto Github PK

None of my ack searches appear to be working . Turning on debug-on-error show the error posted below. (I'm assuming entering "nginx" without the quotation marks should return anything referencing nginx and that there isn't any weird emacs regex code being used.)

This occurs when setting directory explicitly and when letting ack guess. I'm running Emacs 23.1.50 on OS X.

  Debugger entered--Lisp error: (wrong-type-argument integer-or-marker-p nil)
  get-text-property(nil invisible)
  (if (get-text-property beg (quote invisible)) (progn (setq beg ...)))
  (when (get-text-property beg (quote invisible)) (setq beg (next-single-property-change beg ...)))
  (let ((offset 0) next) (when (get-text-property beg ...) (setq beg ...)) (while (and beg ...) (if ... ... ...)) offset)
  ack-visible-distance(nil 80)
  (let ((file ...) (line ...) (offset ...) buffer) (if force (or ... ...) (and file line ...)) (when buffer (with-current-buffer buffer ...)))
  ack-create-marker(80 85)
  (cons (ack-create-marker (match-beginning 2) (match-end 2)) (quote (ack-match t mouse-face highlight follow-link t)))
  (cons (quote ack-marker) (cons (ack-create-marker ... ...) (quote ...)))
  (cons (quote ack-match) (cons (quote ack-marker) (cons ... ...)))
  (cons (quote face) (cons (quote ack-match) (cons ... ...)))

When I try to copy filenames from the results buffer, the color codes are at least partially still there, so I end up with lines such as:

[0m
�[1;33m

Since (I think) these are all replaced by overlays, could the raw codes be removed?

Currently in ack buffer you have to place the cursor on a match to jump to the match. It would be nice if RET would work on the whole line.

On Aquamacs 2.2, I get

With full-ack 2.1 :
error in process filter: ack-visible-distance: Wrong type argument: number-or-marker-p, nil
error in process filter: Wrong type argument: number-or-marker-p, nil
finished with 0 matches

With full-ack 2.2 :

error in process filter: if: Args out of range: 0, 0
error in process filter: Args out of range: 0, 0
Ack finished with 0 matches

Ideally pressing "g" in ack buffer should start the same search again.

Like the way result are clickable in grep-find.

When ack gets the option --context, it correctly identifies that no argument was given, and defaults to 2. However, when it gets the option --context=0, it cannot see that it was not given, because Perl considers the value 0 to be falseish.

The same problem occurs in full-ack.el. I've fixed it in my local copy, but I'm useless at git, so I have my .emacs checked into svn. Hopefully this diff is helpful, nonetheless:

--- full-ack.el       (revision 1084)
+++ full-ack.el       (working copy)
@@ -364,7 +364,8 @@
       (push "-i" arguments))
     (unless regexp
       (push "--literal" arguments))
-    (push (format "--context=%d" ack-context) arguments)
+    (when (not (eq ack-context 0))
+      (push (format "--context=%d" ack-context) arguments))
     arguments))

 (defun ack-run (directory regexp &rest arguments)

Once I've got the results, it would be wonderful if I could edit (similar to string-replace) the results and have it work across the buffers that contain the results.

I'm a happy full-ack user at home with OS X, but at work I have to use Windows.

I have ack.pl (1.96) in c:\bin which is in my path. I have full-ack (0.2.3) installed in GNU Emacs 23.3.1.

When I run full-ack (M-x ack) I get an ack buffer but nothing else.

Hi,

I would like to package full-ack for Gentoo.

Could you please tag a new release? The latest one seems to be a bit outdated.