nref / 560

CS560 lab submissions

560's Issues

Schedule time to talk about filesystem

There's a fair bit I can get through code reviews and git comments but I think we should meet sometime this week to hash things out.

Fix double free on hydra machines

Calling fs_safeclose->fclose() when the file pointer is closed will result in 'unexpected behavior` according to the man page:

Upon successful completion 0 is returned. Otherwise, EOF is returned and errno is set to indicate the
 error. In either case any further access (including another call to fclose()) to the stream results in 
undefined behavior.

On the hydra lab machines, this just means an double free message and an error.
2 fixes are to:

• Reset the file pointer to null after every successful call to fclose
• Rewrite the code to call safeclosed accordingly and write code to detect a closed fp