Comments (1)
This is a serious security risk. Consider something like
npx write-script > output.js \
--footer '// Run `rm -rf $PATH_TO_YOUR_PROJECT/**` to clean'
where the script author has enclosed rm -rf …
in single-quotes to avoid executing it. Since $PATH_TO_YOUR_PROJECT
is unlikely to be defined in one's environment, NPM ends up running something like
sh -c write-script "--footer" "// Run `rm -rf /**` to clean"
... at which point, it's game over.
The problem extends to usage of $
as well, which isn't escaped because it isn't a metacharacter in JSON, but it sure as hell is in shell-scripts ($(cmd)
, ${variable_name}`, etc).
from run-script.
Related Issues (20)
- [BUG] #98 breaks AIX HOT 3
- Reporting a vulnerability HOT 1
- [BUG] Package is not in npm registry HOT 5
- [feature request] Indent output of nested `npm` commands
- [BUG] npm start ignores empty argument on windows
- deps: move to @npmcli/package-json HOT 1
- [BUG] The `npm_config_node_gyp` environment variable and `npm config set node-gyp` config don't work with npm 7 HOT 2
- [BUG] 1.8.4 is failing on npm/cli integration tests HOT 2
- Upgrade node-gyp to v.8.0.0 to prevent deprecation errors HOT 2
- [BUG] npm run-scripts fail in windows 10 with case-sensitivity enabled. HOT 2
- [FEATURE] Typescript Types HOT 3
- Update node-gyp to avoid npm install warnings HOT 1
- [BUG] Migrate to `node-gyp@^8` HOT 2
- [?BUG] package.json -> process.env - Array is smashed, while object can be deep HOT 1
- [BUG] Can not build binary packages on Debian Stretch HOT 4
- [QUESTION] how to show logs in terminal HOT 1
- [BUG] v3.0.1 has a breaking change HOT 1
- [BUG] "command not found" when running script with bash as script-shell on Windows HOT 1
- [BUG] BREAKING REGRESSION npm concurrency regression in 4.1.0 and onwards HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from run-script.