Coder Social home page Coder Social logo

Deprecated GetVersionEx about npackd-cpp HOT 6 CLOSED

npackd avatar npackd commented on May 29, 2024
Deprecated GetVersionEx

from npackd-cpp.

Comments (6)

tim-lebedkov avatar tim-lebedkov commented on May 29, 2024

I doubt Microsoft will remove GetVersionEx in the next years. GetFileVersionInfoSize(L"Kernel32.dll",...) seems to be even more fragile. Npackd already has a manifest (https://github.com/tim-lebedkov/npackd-cpp/blob/master/npackdg/src/npackdg.manifest) that shows that it knows about Windows 10 and GetVersionEx works properly.

from npackd-cpp.

OgreTransporter avatar OgreTransporter commented on May 29, 2024

I doubt Microsoft will remove GetVersionEx in the next years. GetFileVersionInfoSize(L"Kernel32.dll",...) seems to be even more fragile.

That's why I replaced GetVersionEx - even if it still works sometimes.

By the way, GetVersionEx in npacked prints the following:

dwOSVersionInfoSize = 276
dwMajorVersion = 6
dwMinorVersion = 2
dwBuildNumber = 9200
dwPlatformId = 2

Correct would be dwMajorVersion = 10 and dwMinorVersion = 0! Obviously, this does not always work correctly with manifest or the manifest is not properly integrated via CMake.

from npackd-cpp.

OgreTransporter avatar OgreTransporter commented on May 29, 2024

Fixed in 0c3714d. Visual Studio had ignored the manifest settings and had written its own manifest.

from npackd-cpp.

tim-lebedkov avatar tim-lebedkov commented on May 29, 2024

Please create a new pull request with CMake changes only where everything builds.

from npackd-cpp.

OgreTransporter avatar OgreTransporter commented on May 29, 2024

PR #49

from npackd-cpp.

OgreTransporter avatar OgreTransporter commented on May 29, 2024

Please create a new pull request with CMake changes only where everything builds.

PR #51

from npackd-cpp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.