Comments (6)
I doubt Microsoft will remove GetVersionEx in the next years. GetFileVersionInfoSize(L"Kernel32.dll",...) seems to be even more fragile. Npackd already has a manifest (https://github.com/tim-lebedkov/npackd-cpp/blob/master/npackdg/src/npackdg.manifest) that shows that it knows about Windows 10 and GetVersionEx works properly.
from npackd-cpp.
I doubt Microsoft will remove GetVersionEx in the next years. GetFileVersionInfoSize(L"Kernel32.dll",...) seems to be even more fragile.
That's why I replaced GetVersionEx - even if it still works sometimes.
By the way, GetVersionEx in npacked prints the following:
dwOSVersionInfoSize = 276
dwMajorVersion = 6
dwMinorVersion = 2
dwBuildNumber = 9200
dwPlatformId = 2
Correct would be dwMajorVersion = 10
and dwMinorVersion = 0
! Obviously, this does not always work correctly with manifest or the manifest is not properly integrated via CMake.
from npackd-cpp.
Fixed in 0c3714d. Visual Studio had ignored the manifest settings and had written its own manifest.
from npackd-cpp.
Please create a new pull request with CMake changes only where everything builds.
from npackd-cpp.
PR #49
from npackd-cpp.
Please create a new pull request with CMake changes only where everything builds.
PR #51
from npackd-cpp.
Related Issues (20)
- Merge Software with multible Architecture or Software with add-on HOT 6
- Feature request: Optional custom proxy settings
- Warn me if uninstallation isn't 100% successful HOT 7
- Wrong help text HOT 4
- Update all HOT 3
- Reconsider the process of exporting packages HOT 3
- software not detected HOT 3
- scan multiple folders HOT 3
- need help: transform npackd into a portable app HOT 5
- taskschd.lib is missing
- Win2004_x64 19041.508 AMD Graphic Bug ? HOT 2
- Thank you very much for the free open source program! HOT 1
- Darktable and KDE Connect HOT 2
- how to avoid creating .npackd directory in program files? HOT 6
- Installation does not work when version is specified in the update command. HOT 4
- Invalid SEH
- Try "Package/Check dependencies". HOT 1
- Scripts terminate with "unresolved dependencies..." HOT 7
- Visual Studio Code is uninstalled on my machine but is still listed as installed in Npackd HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from npackd-cpp.