notmike101 / betterdiscord-even-better-repo

A better implementation of a repository for themes & plugins for BetterDiscord

Hi 👋! My name is Mike and I'm a software engineer that gets bored a lot

👨‍💻 My personal website and notable projects are available at https://mikeorozco.dev

betterdiscord-even-better-repo's Issues

Repo Update - Theme - Full Dark

Theme Name: Full Dark
Theme Author: fluffy
Theme Repo URL: https://github.com/fluffingtons/fulldark
Theme Direct URL: https://raw.githubusercontent.com/fluffingtons/fulldark/master/fulldark.theme.css
Theme Description: A theme which aims to complete the dark theme for Discord.

CasualDark theme

came as CasualDark.css instead of CasualDark.theme.css

Quicksave Links to Wrong Plugin

It links to the Compact Guilds Plugin which isn't listed elsewhere in the repo.

Offending Lines
Actual Link

Doesn't properly handle failed downloads

On 4xx errors, should report a useful error to the user, and not place junk into the plugins/themes folder.

On 5xx errors, should maybe report the issue and auto-retry a few times.

Repo Update - Theme - Example Theme

Plugin Name: EvenBetterRepo
Plugin Author: IRDeNial
Plugin Author GitHub URL: https://github.com/IRDeNial/
Plugin Repo URL: https://github.com/IRDeNial/BD-Even-Better-Repo/
Plugin Direct URL: https://raw.githubusercontent.com/IRDeNial/BD-Even-Better-Repo/master/evenBetterRepo.plugin.js
Plugin Description: A better implementation of a repository for themes & plugins for BetterDiscord

Plugin/Theme info is not properly escaped

Although malicious XSS isn't a likely risk here, there's still the possibility of plugin/theme info being improperly rendered due to the lack of escaping. For example, the EmbedAV plugin includes <video> and <audio> in its description text.

not working

this plugin is now working, i installed it and restarted discord but it still is not working and yes i read the instructions exactly how it says

EvenBetterDiscord

Plugin Name: EvenBetterDiscord
Plugin Author: DeathStrikeV
Plugin Author GitHub URL: https://github.com/DeathStrikeV/
Plugin Repo URL: https://github.com/DeathStrikeV/EvenBetterDiscord
Plugin Direct URL: https://raw.githubusercontent.com/DeathStrikeV/EvenBetterDiscord/master/EvenBetterDiscord.plugin.js
Plugin Description: Loads FFZ emotes from alternate repository

Repo Update - Plugin - Theme Customizer

Plugin Name: Theme Customizer
Plugin Author: Zerthox
Plugin Author GitHub URL: https://github.com/Zerthox/
Plugin Repo URL: https://github.com/Zerthox/BetterDiscord-Plugins/
Plugin Direct URL: https://raw.githubusercontent.com/Zerthox/BetterDiscord-Plugins/master/plugins/ThemeCustomizer.plugin.js
Plugin Description: Customize CSS variables of themes

Add Support For OSX

File saving is done using Windows specific paths. Need to add support for OSX filesystem in order to allow for Mac users to use the plugin.

Repo Update - Theme - Kobato

Theme Name: Kobato
Theme Author: Syaoran3
Theme Author GitHub URL: https://github.com/DRedDogPE/
Theme Repo URL: https://github.com/DRedDogPE/DiscordThemes/tree/master/Kobato
Theme Direct URL: https://raw.githubusercontent.com/DRedDogPE/DiscordThemes/master/Kobato/Kobato.theme.css
Theme Description: A Kobato theme made for EternalEnd

Smoothieland

Repo Update - Plugin - Kawaii Emotes

Plugin Name: Kawaii Emotes
Plugin Author: noodlebox
Plugin Author GitHub URL: https://github.com/noodlebox
Plugin Repo URL: https://github.com/noodlebox/betterdiscord-plugins
Plugin Direct URL: https://raw.githubusercontent.com/noodlebox/betterdiscord-plugins/master/KawaiiEmotes.plugin.js
Plugin Description: Better emote parsing for BetterDiscord. Fixes bugs with emotes and tooltips.

Repo Update - Theme - Dark Cyan (Flat & Edgy)

Theme Name: Dark Cyan (Flat & Edgy)
Theme Author: マギルゥーベルベット (magiruuvelvet)
Theme Author GitHub URL: https://github.com/magiruuvelvet
Theme Repo URL: https://github.com/magiruuvelvet/discord-theme-dark-cyan-flat-edgy/tree/master
Theme Direct URL: https://raw.githubusercontent.com/magiruuvelvet/discord-theme-dark-cyan-flat-edgy/master/dark-cyan-flat-edgy.theme.css
Theme Description: A dark cyan and flat & edgy theme for Discord
Preview Screenshot: https://raw.githubusercontent.com/magiruuvelvet/discord-theme-dark-cyan-flat-edgy/master/screenshots/main-ui.png

Plugins are saved in theme folder if they do not end in "plugin.js"

dest = theme_path + url.substr(url.lastIndexOf('/') + 1) + '.plugin.js';

Should be plugin_path

Thank you @🎮Mitchell🎮#5985

Automate validation of repo data

Some build tools to help validate repo data could be handy. At the very least, check URLs for 404s so that they may be corrected or removed.

Repo Update - Plugin - Toggle All

Plugin Name: Toggle All
Plugin Author: Zerthox
Plugin Author GitHub URL: https://github.com/Zerthox/
Plugin Repo URL: https://github.com/Zerthox/BetterDiscord-Plugins/
Plugin Direct URL: https://raw.githubusercontent.com/Zerthox/BetterDiscord-Plugins/master/plugins/ToggleAll.plugin.js
Plugin Description: Enable/disable all plugins or themes with a button

Incompatible with new settings panel

Repo Update - Plugin - Line Numbers

Plugin Name: Line Numbers
Plugin Author: noodlebox
Plugin Author GitHub URL: https://github.com/noodlebox
Plugin Repo URL: https://github.com/noodlebox/betterdiscord-plugins
Plugin Direct URL: https://raw.githubusercontent.com/noodlebox/betterdiscord-plugins/master/LineNumbers.plugin.js
Plugin Description: Add line numbers to code blocks.

Test

This is a test
@Anxeal

Implement automatic version checking and updates for installed plugins/themes

Repo data should include version numbers to allow the EBR plugin to notify users of updates, or to automatically install them.

Version numbers can be automatically parsed from theme META lines. Plugins could potentially include their version here too, but the current convention is to just implement getVersion(). An automated process could run each plugin in a sandbox and call its getVersion() as a part of its general validation (#71). The GitHub API could also be used to preemptively check whether the commit hash has changed, to decide whether downloading and parsing the files themselves is even necessary at all.

Creating a commit for every change in version number might be excessive. The original repo.json could be used to maintain the list of relatively static URLs, and the "extended" repo data could be served by the same server that performs the validation and version checking.

Ideally, plugin/theme authors should also adhere to the semantic versioning standard.