notbad4u / query_params Goto Github PK

Hi,
It's just idea.

There is a quite good url lib that could match your library.

There is a set_query method that near match your to_query_params().

Your generate ?sth=2 url accept Some("sth=2") (without ?). I think it would be nice to make your solution merged. Serialize structures with derive is nice future.

Problem occurs when your struct contains only Option and you can generate empty str.

let generated_query =  structure.to_query_params();
if generated_query.len() > 0 {      
      url.set_query(Some(&generated_query.as_str()[1..]));     
  }

I will link to this issue from url. Maybe sb will be interested and find a nice solution.

This doesn't handle values containing special characters correctly, because it doesn't escape them. This is particularly problematic for & and =, since these will now be interpreted as separate parameters. This could lead to security vulnerabilities, similar to SQL-Injection or XSS.