nomatteus / dinesafe Goto Github PK

• Add hash check to compare old/new file when checking XML file in rake task.
• If hash is the same then stop running.
• Right now it always runs the import daily which is unnecessary and kills the droplet.

Something to consider

Instead of the custom get_distance_km function, look into using these postgres extensions: cube and earthdistance:

• http://www.postgresql.org/docs/9.3/static/cube.html
• http://www.postgresql.org/docs/9.3/static/earthdistance.html

Check out this tutorial: http://johanndutoit.net/searching-in-a-radius-using-postgres/

Should be faster as these are official extensions, not some random function. Profile some queries and test it out to be sure!

Note that the above assumes the earth to be perfectly spherical. Should be accurate enough though. (But if not, the PostGIS is the answer...).

Also note: Since this is a significant change, and will likely require changing db structure etc., set up another digital ocean server to use as a dev server. But then promote it to be the production server when it's ready. Use the next fastest one! ($10/mo, 1GB RAM) Right now it's chugging...

Same as nomatteus/dinesafe-ios#7 but on the site.

Relevant page: http://dinesafe.to/app/about

• Setup with app stack
• Goal: Run one-command, (drink some coffee and wait), then app is running.
• Use parallels

JBuilder is taking ~300ms to render. DB queries have been speed up a lot (from ~600ms to ~120ms), and now JBuilder is the bottleneck.

Even just using ditching jbuilder partials cuts view loading time in half. But just skip that and render JSON directly.

Data is available in CSV, XML, and XLS formats: http://opendata.peelregion.ca/data-categories/food-check/food-check-peel.aspx

Notes:

• Says filenames/paths will remain static, so makes it easy to automate.
• Updated weekly.
• Data structure is roughly the same as Dinesafe. The 'scorebar' will work.
• Adds notion of "Inspection Type": Routine (or "scheduled"), and Re-inspection.

• At least latest point release (for any security fixes)
• Try upgrading to Rails 4.2.

For whatever attributes we want to filter on:

• Add boolean (or appropriate type) column, and add hooks to keep the field updated (denormalized). With tests.
• Add endpoints or query params to allow filtering by these types.

Some ideas:

• perfect_record: All inspections passed. Gold star! (Should places that have all passed but some infractions still count as perfect? Maybe not... see what the #'s are like.)
• long-term safety (?): A place that has been around for a while (say at least 2 or 3 years), has passed all inspections, and has no crucial infractions. Basically like above but a subset of places that have been open for quite a while.
• has_been_closed: Any place that has been closed at any time in the past. This is an interesting one--allows you to see a list of all the places that have closed...
• has_had_conditional: Any place with at least one conditional.
• has_recent_conditional: Any place with at least one conditional in the past X time period. (where perhaps X = a year?)
• has_crucial_infraction: Has at least one inspection that had a crucial infraction. Could do same for significant.
• ...:

Improvements:

• Improve spelling correction.
• Don't require exact text (including punctuation) - aka fuzzy search

Tech:

• Look into use postgres trigrams: http://www.postgresql.org/docs/9.3/static/pgtrgm.html
• https://www.google.ca/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8#q=postgres%20search%20trigrams
• If that's not good enough, look into other options.

• Apparently the feed has been updated to remove certain types of establishments.
• In general, should get rid of any place that is not in the current feed.