noheltcj / rxcommon Goto Github PK

Probably the biggest blocker in this case is that state can be accidentally modified simultaneously by separate concurrent threads. Each platform will require separate implementations.

Title explains itself. The goal is to make the library more accessible.
Ideally, the wiki would cover each source type and the operators.

Regression/integration tests covering the Source's doOnError and doOnComplete methods including making sure that the operator itself always properly disposes the upstream and removes observers from the emitter when the created disposables are disposed.

Hi, thank you for this project, i just wanted to be sure that you are aware that https://github.com/badoo/Reaktive is also working on multiplatform Rx. Maybe you can kind of work together

Due to the fact that the disposable created when adding the subject as an observer of the upstream source is not exposed by the subscribeTo method, cleanup is not possible.

The delay operator will likely need to have multiple platform dependent implementations.

Delay should shift emissions and the complete notification by the specified amount of time (timeshiftInMillis: Long). An error notification should still propagate immediately downstream and dispose the upstream subscription.

Happy to collaborate if anyone wants to take this one.

Discovered MMP a couple of weeks back, thought ho no there is no rx.. Didn't not thought It would come so quickly thank for the great job !

Reading your readme especially "I personally use the existing platform specific implementations of Rx (RxSwift, RxJava, etc) combined with platform scheduling (ExecutorService, DispatchQueue, etc) to do this." Could you provide a minimal example with RxCommon and RxSwift/RxJava ? I'm interested in the setup / conversion between observables

While it's possible to work around not having this. Semantically, the workaround does not fit.

Currently, the emitter is public for Single. This should not be directly accessible.