node-modules / common-bin Goto Github PK

const Command = require('common-bin')

class SubBin extends Command {
  constructor(args) {
    super(args)

    // For example load some commander
    this.load('path/to/command(include test, dev, cov)')
  }
}

class MyBin extends SubBin {
  constructor(args) {
    super(args)

    this.load('path/to/mycommand(include run)')
  }
}

module.exports = MyBin

So, My question is how can I disable some SubBin Command

问题就是我想仅仅继承于 SubBin 的一部分命令，但是其他的我又不想要，或者不想要在 help 里面显示出来，有没有提供 disable command 的接口？

Since some packages are vulnerable, such as [email protected]

tsconfig.json

{
  "compilerOptions": {
    "module": "commonjs",
    "outDir": "./lib",
    "target": "es2015",
    "moduleResolution": "node",
    "strict": true,
    "sourceMap": true,
    "removeComments": true,
    "importHelpers": true,
    "noEmitOnError": false,
    "noImplicitAny": false,
    "skipLibCheck": true,
    "declaration": true,
  },
  "exclude": [
    "node_modules",
    "lib"
  ],
  "include": [
    "./src/**/*"
  ]
}

If use es module will throw a error.

import * as Command from 'common-bin';

export default class CheckCommand extends Command {
  constructor(rawArgv: string[]) {
    super(rawArgv);
    this.yargs.usage('check me');
  }

  run(context: Command.Context) {
    
  }

  get description(): string {
    return 'Clone a repository into a new directory';
  }
}

The error:

AssertionError [ERR_ASSERTION]: command class should be sub class of common-bin
    at MainCommand.add (/Users/hacke2/projj/gitlab.alipay-inc.com/xinglong.wangwxl/vscode-extension-scan/node_modules/[email protected]@common-bin/lib/command.js:109:7)
    at MainCommand.load (/Users/hacke2/projj/gitlab.alipay-inc.com/xinglong.wangwxl/vscode-extension-scan/node_modules/[email protected]@common-bin/lib/command.js:86:14)
    at new MainCommand (/Users/hacke2/projj/gitlab.alipay-inc.com/xinglong.wangwxl/vscode-extension-scan/lib/index.js:9:14)
    at Object.<anonymous> (/Users/hacke2/projj/gitlab.alipay-inc.com/xinglong.wangwxl/vscode-extension-scan/lib/bin/vc.js:5:1)
    at Module._compile (internal/modules/cjs/loader.js:721:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:732:10)
    at Module.load (internal/modules/cjs/loader.js:620:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:560:12)
    at Function.Module._load (internal/modules/cjs/loader.js:552:3)
    at Function.Module.runMain (internal/modules/cjs/loader.js:774:12)

command constructor

constructor (rawArgv) {
    super(rawArgv)
    this.options = {
      lib: {
        type: 'boolean',
        default: false,
        description: 'whether library mode'
      }
    }
  }

scripts

"start": "npm run command serve --lib",
"start": "yarn run command serve --lib", // when use yarn
"command": "node ../../bin/command.js"

result

npm(the lib argument is false)

{ _: [],
  lib: false,
  '$0': '..\\..\\bin\\command.js',
  help: undefined,
  h: undefined,
  version: undefined,
  v: undefined }

yarn(this lib argument is true)

{ _: [],
  lib: true,
  '$0': '..\\..\\bin\\command.js',
  help: undefined,
  h: undefined,
  version: undefined,
  v: undefined }

Hi, @atian25 @fengmk2, there is a vulnerability introduced by package ** [email protected]**:

Issue Description

I noticed that a vulnerability is introduced in [email protected]:
Vulnerability CVE-2020-7608 affects package yargs-parser (versions:>5.0.0-security.0 <5.0.1,>=6.0.0 <13.1.2,>=14.0.0 <15.0.1,>=16.0.0 <18.1.1): https://snyk.io/vuln/SNYK-JS-YARGSPARSER-560381
The above vulnerable package is referenced by [email protected] via:
[email protected] ➔ [email protected] ➔ [email protected]

Since [email protected] (36,523 downloads per week) is referenced by 68 downstream projects (e.g., egg-scripts 2.14.0 (latest version), egg-bin 4.16.4 (latest version), surgio 2.9.1 (latest version), cabloy 4.11.16 (latest version), midway-bin 1.20.3 (latest version)), the vulnerability CVE-2020-7608 can be propagated into these downstream projects and expose security threats to them via the following package dependency paths:
(1)[email protected] ➔ [email protected] ➔ [email protected] ➔ [email protected] ➔ [email protected]
(2)[email protected] ➔ [email protected] ➔ [email protected] ➔ [email protected] ➔ [email protected]
......

If [email protected] removes the vulnerable package from the above version, then its fixed version can help downstream users decrease their pain.

Given the large number of downstream users, could you help update your package to remove the vulnerability from [email protected] ?

Fixing suggestions

In [email protected], maybe you can kindly try to perform the following upgrade :
yargs ^12.0.2 ➔ ^13.1.0;

Note:
[email protected](>=13.1.0 <14.1.0) directly depends on [email protected] which has fixed the vulnerability CVE-2020-7608.

Thank you for your attention to this issue and welcome to share other ways to resolve the issue.^_^

• Node.js 14.x+
• update deps
• remove generator function
• forkNode -> execa
• use clet instead of coffee
• use jest instead of egg-bin / mocha

like this:

const child = this.helper.forkNode();
child.on('message', () => {
});

I tried to run the following example of the test/fixtures/my-git ，I run it in local：

-- cd common-bin/test/fixtures/my-git

-- npm run my-git clone gh://node-modules/common-bin dist --depth=1

I get something like this：

{ _: [ 'gh://node-modules/common-bin', 'dist' ],
  '$0': 'bin/my-git.js',
  help: undefined,
  h: undefined,
  version: undefined,
  v: undefined }
git clone undefined to undefined with depth NaN

and I want to know why this is not consistent with what I expected ?

英语看着吃力：）

Missing license in package.json