Comments (5)
with the patch to fix the problem where you cannot submit multiple fields with the same name
There is no such problem, if you listen to the 'file'
events directly.
If the browser posts a multi-part POST request with no parts
How would this happen? By submitting a form without any fields in it?
--fg
from formidable.
Yes, no fields. I have a section of a page where the presence of the fields is dependent on app state. I had to add a dummy hidden field to work around this problem. It would not have been a big deal if I had not spent a full day chasing it down. Maybe this post can save another person the same trouble.
I do appreciate your efforts and the usefulness of Formidable. However, I will argue one last time about the feature that provides the fields in an object. This feature loses data and is broken. You should either pull the feature or fix it.
You can stubbornly argue that since one can work around this bug that it is not a bug. You are free to do this. I am also stubborn and I do not want to learn how to code listeners in Formidable. I was able to quickly install Formidable and start using it without even realizing it had events. The friendly patch that you refuse to pull solves my problem nicely.
You mentioned "purity" in a recent post. This feature bug is definitely impure. My coding event listeners would be an impure kludge.
That's it. I'll shut up now and quit sowing FUD.
Mark Hahn
Website Manager
[email protected]
from formidable.
Thanks for the bug report, I'll look into it.
You can stubbornly argue that since one can work around this bug that it is not a bug.
I think as the author of the module, I get to define the expected behavior of it. What you are calling a bug, is a leaky abstraction. I will certainly address it in a future release, but please note the difference between this problem, and the actual bug you discovered and reported in this ticket. One is the result of a conscious choice of mine that didn't find popular appeal, the other is a defect in the Software that I had no awareness of having introduced.
--fg
from formidable.
I apologize for mixing the two together. I was originally just trying to state in some way what version I was running. Then I got carried away (as usual) in the follow-up discussion.
Thanx for the great sw.
from formidable.
No harm done, and thanks again for the bug report, I hope to fix this ASAP : )
from formidable.
Related Issues (20)
- discard file keeping the other form values HOT 5
- Do we have plan to rewrite logic in typescript for more clear structure? HOT 1
- Encrypting a stream received via Formidable.js before streaming to S3 fails HOT 2
- Formidable V2 Filter issue HOT 2
- is v3 ESM only? HOT 8
- null values are parsed into 'null' string HOT 2
- Migration guide from v2 to v3? HOT 4
- What are the breaking changes in v3.0.0? HOT 4
- formidable is stuck at parse function's callback HOT 9
- Formdata is string, but parse resulting is array? HOT 3
- TS Options Type Definition missing createDirsFromUploads HOT 1
- Attach fields to req.body and files to req.files like multer HOT 1
- [deps] Check for breaking changes in Dependabot PRs HOT 1
- @cunha-ambisis you should create a new form on each request (inside app.use) HOT 1
- Since V3 I get "formidable is not a function" - using require not import HOT 12
- Make multipart parser less dependent on NodeJS HOT 2
- Regression in Formidable v3, which can crash a server HOT 7
- form.parse's Promise never resolves in tests HOT 8
- Hexoid Error (?)
- Buffer usage HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from formidable.