Coder Social home page Coder Social logo

is v3 ESM only? about formidable HOT 8 CLOSED

phpbg avatar phpbg commented on July 20, 2024
is v3 ESM only?

from formidable.

Comments (8)

GrosSacASac avatar GrosSacASac commented on July 20, 2024 1

Published [email protected]

from formidable.

GrosSacASac avatar GrosSacASac commented on July 20, 2024

Did you read the changelog ?

from formidable.

hannesfant avatar hannesfant commented on July 20, 2024

Yes

* feat: Use ES modules ([#727](https://github.com/node-formidable/formidable/pull/727))

I think @GrosSacASac could have said it immediately instead, since it's quite buried in the changelog, and most users don't read it to begin with. Just answering the question immediately would save everyone a lot of time, but that's just my opinion :)

from formidable.

phpbg avatar phpbg commented on July 20, 2024

Hi,

yes, I did read the changelog, but AFAIK the fact that you internally use ESM does not imply that you don't built with commonJS support (sorry i'am not sure about it).

At least I would say it is not quite obvious, and it is not a feature, but a breaking change...

from formidable.

GrosSacASac avatar GrosSacASac commented on July 20, 2024

Is it a good idea to make it work both with commonjs and esmodules ?

from formidable.

phpbg avatar phpbg commented on July 20, 2024

Is it a good idea to make it work both with commonjs and esmodules ?

Well, it depends on your v2 vs v3 strategy.

If you want to promote v3 for everyone, I suggest you make it work for both.

Anyway it would be great to make a clear statement in your readme

from formidable.

GrosSacASac avatar GrosSacASac commented on July 20, 2024

#944

from formidable.

phpbg avatar phpbg commented on July 20, 2024

Thank you!

I guess I have to move on 3.5+ now ;-)

from formidable.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.