nobl9 / nobl9-go Goto Github PK

We are writing some internal APIs to manage nobl9 objects. Any suggestions on how I should mock the client for unit testing?
Currently mocking the methods which we are actually using.
e.g.

type N9Client interface {
	GetUser(ctx context.Context) (string, error)
	GetProjects(ctx context.Context, projectName string) ([]project.Project, error)
	CreateProject(ctx context.Context, projectName string) error
	DeleteProject(ctx context.Context, projectName string) error
}

Was wondering if we could pass the mockedClient to actual SDK and then SDK holds these mocked methods.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

This repository currently has no open or pending branches.

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Describe the bug
Double quoted, multiline strings result in an error and are not handled properly by sdk.ReadObjects function.

To Reproduce

Minimal main.go:

package main

import (
	"context"
	"fmt"

	"github.com/nobl9/nobl9-go/manifest"
	"github.com/nobl9/nobl9-go/manifest/v1alpha/project"
	"github.com/nobl9/nobl9-go/sdk"
)

func main() {
	objects, err := sdk.ReadObjects(context.Background(), "./project.yaml")
	if err != nil {
    panic(err)
	}
	fmt.Println(manifest.FilterByKind[project.Project](objects)[0].Spec.Description)
}

project.yaml:

apiVersion: n9/v1alpha
kind: Project
metadata:
    name: test
spec:
  description: "This operation includes the following processes: <br>
- Get all orders in a particular timeframe
"

Expected behavior

The object should be parsed just fine, the YAML library parses the file just fine on its own, which might hint at quoting handling issues on our side.
Here's a minimal working exmaple:

package main

import (
	"fmt"
	"os"

	"github.com/nobl9/nobl9-go/manifest/v1alpha/project"
  "github.com/goccy/go-yaml"
)

func main() {
	data, err := os.ReadFile("./project.yaml")
	if err != nil {
		panic(err)
	}
	var project project.Project
	if err = yaml.Unmarshal(data, &project); err != nil {
		panic(err)
	}
	fmt.Println(project.Spec.Description)
}

System details (please complete the following information):

• Fedora 37
• 0.77.1

Describe the bug
Property errors for map keys validation do not handle empty strings. Instead of a path like metadata.labels."" we get metadata.labels.

To Reproduce
Set map key to an empty string, run validation. The result is a property path without the empty string key element.

Expected behavior
The result should be a valid YAMLPath pointing at the empty key.