Coder Social home page Coder Social logo

gulp-aglio's People

Contributors

gsong avatar jaime-franco avatar nnnnathann avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

gulp-aglio's Issues

aglio includes don't work

Because this is run from gulp, trying to include paths in the .md files is always looking for them in the root directory.

includePath string process.cwd() Base directory for relative includes.

Theme gets always overwritten by 'default'

Currently the index.js says the default theme should be 'default'. However, this default always overwrites the provided 'theme' you actually want.

It currently says the following:
var opts = defaults({ theme: 'default' }, options);

However, since we want to use our own theme, it should be the other way around otherwise it gets always overwritten by 'default':

var opts = defaults(options, { theme: 'default' });

Is there any specific reason why you set it explicitly to 'default'? If not, can you please provide the fix so it only falls back to the 'default' when there is no theme provided?

Options are not passed to aglio

On line 38 you're only passing the theme key from options. Why aren't you passing the entire options object?

Currently as it stands, I can't pass any options to aglio.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.