nmetulev / graph-react-starter Goto Github PK

ideally, we should suggest or provide something like boostrap, material or other grid/style systems to setup common layouts without having to fight with CSS incantations.

Is Fabric core the suggested approach here? https://developer.microsoft.com/en-us/fluentui#/get-started/web#fabric-core

I was able to load the site but not able to login using my M365 dev tenant. I approved access as requested. Tried a real tenant I have as well. Got this error for both:

I then tried doing the same thing with an "in private" mode browser but got the same error. Could be my tenant...not sure?

First time I ran yarn I got this error.

error An unexpected error occurred: "https://registry.yarnpkg.com/@jest/console/-/console-24.9.0.tgz: 
ENOENT: no such file or directory, open '/usr/local/share/yarn-cache/v4/[email protected]
79b1bc06fb74a8cfb01cbdedf945584b1b9707f0/node_modules/@jest/console/.yarn-tarball.tgz'".

Ran it again and it was fine though. Might be a Github Codespaces thing (haven't tried locally)?

After running yarn start in Github Codespaces a warning appears due to deps and options not being passed into the useGet hook dependency list. That blocked seeing the URL that I need to click for the forwarding Codespaces does.

I updated the useGet dependencies to [isSignedIn, resource, deps, options] and the warning went away. Haven't look if adding those breaks anything else though.

const [user, userLoading ] = useGet<User>('/me');

which calls

export function useGet<T = any>(resource: string, deps?: unknown[], options?: GetOptions) : [T | undefined, boolean, any] {}

is practical but a bit obscure and hard to discover. Ideally, we are probably looking to get close to something like:
User.current or something like that, right?

useGet makes it easier to make the HTTP call but one needs to know that to get the current user, they need to make a get request that will return a User instance by call the /me URI. That's quite a lot to discover for a pretty common action, isn't it?

./src/mgt.ts
Line 58:6: React Hook useEffect has missing dependencies: 'deps' and 'options'. Either include them or remove the dependency array react-hooks/exhaustive-deps

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.