nmcassa / letterboxdpy Goto Github PK

Some meta data for new or very small movies aren't added.
Searching through some movies it looks like they just arent there.

Probably need to add some try catches and just not populate some variables for movies

If you begin the movie title with a capital letter, for example:

if __name__ == "__main__":
    king = Movie("King kong")
    print(king)

You get:

...
Traceback (most recent call last):
  File "/opt/homebrew/lib/python3.10/site-packages/letterboxdpy/movie.py", line 178, in <module>
    king = Movie("King kong")
  File "/opt/homebrew/lib/python3.10/site-packages/letterboxdpy/movie.py", line 25, in __init__
    self.movie_genre(page)
  File "/opt/homebrew/lib/python3.10/site-packages/letterboxdpy/movie.py", line 91, in movie_genre
    raise Exception("No movie found")
Exception: No movie found

To resolve, you could either update the README to reflect this or update https://github.com/nmcassa/letterboxdpy/blob/main/src/letterboxdpy/movie.py#L14 to automatically convert the title to lowercase with:

self.title = title.replace(' ', '-').lower()

Just using the code in the movie example in the readme:

from letterboxdpy import movie
king = Movie("king kong")
print(king)
king = Movie("king kong", 2005)
print(king)
house = Movie("/film/the-house-2022-1/")
print(house)

I get:

Traceback (most recent call last):
  File "/Users/bs/Sites/Letterblocksd/Scripts/newScraper/BeScrapes.py", line 2, in <module>
    king = Movie("king kong")
           ^^^^^
NameError: name 'Movie' is not defined. Did you mean: 'movie'?

I believe the readme should have movie.Movie

Traceback (most recent call last):
  File "C:\Users\user\react\letterboxdwatchlist\backend\api.py", line 17, in <module>
    movie_instance = movie.Movie("eline-vere")
                     ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\user\AppData\Local\Programs\Python\Python312\Lib\site-packages\letterboxdpy\movie.py", line 27, in __init__
    self.movie_rating(dom, script)
  File "C:\Users\user\AppData\Local\Programs\Python\Python312\Lib\site-packages\letterboxdpy\movie.py", line 56, in movie_rating
    script['aggregateRating']['ratingValue'] if script else None
    ~~~~~~^^^^^^^^^^^^^^^^^^^
KeyError: 'aggregateRating'

Movie link: https://letterboxd.com/film/eline-vere/
I am on latest git version
pip install git+https://github.com/nmcassa/letterboxdpy.git
To reproduce

from letterboxdpy import movie
movie_instance = movie.Movie("eline-vere")
print(movie_instance)

I think there should be a check whether a movie has a rating or not.

Hey!
Firstly i'd like to sat that this seems to be a great project but I am getting an FeatureNotFoundError while trying to run the code

I have installed bs4 and lxml

It would be a great if you could help me with this!!

The wheel for letterboxdpy 4.0 is buggy — it installs src/letterboxdpy instead of letterboxdpy and it doesn't contain __init__.py. See the bug in action at https://stackoverflow.com/questions/77542786/modulenotfounderror-no-module-named-letterboxdpy/77542850

Movies that have the same title (arrival (2013), arrival (1980), arrival (2016)) have different url's with the year in the top.
So far no way to specify movie.

Could search the name and pick the most popular.
Could add a constructor that takes a year to get more accurate.

Hello, I've used letterboxdpy in the past with no issues at all, but just to gather data about movies.

I'm tying now to do the same with users, but I keep getting the errors ''NoneType object has no attribute 'text'' and then 'No user found', even when using the example provided in the readme.md.

from letterboxdpy import user
nick = user.User("nmcassa")
print(nick)

these are the errors I get:

Thank you in advance.